Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-15 Thread Owen Rudge
Hi Detler, > Disassembling Windows Code is not allowed for Wine. > You should have know that and you should know the result. I'd just like to explain what it was exactly that I did, to possibly clear up any confusion. After submitting a set of patches, and receiving the comment that HIMAGELIST

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-15 Thread Detlef Riekenberg
On Mi, 2009-08-12 at 23:31 +0100, Owen Rudge wrote: > > You can't do that. HIMAGELIST should be the same thing as IImageList. > > Hmm. Looking at the HIMAGELIST/IImageList internals in a debugger on > Windows, the layout appears to be ... :-( Disassembling Windows Code is not allowed for Wine.

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-12 Thread Nikolay Sivov
Owen Rudge wrote: This layout is not officially published anywhere, however (nor is the new one), so I presume it will be acceptable to modify it to fit the vtable and reference count, etc, in? Personally I don't see another way to do so. It might conceivably cause problems for any pre-comctl32

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-12 Thread Owen Rudge
This layout is not officially published anywhere, however (nor is the new one), so I presume it will be acceptable to modify it to fit the vtable and reference count, etc, in? It might conceivably cause problems for any pre-comctl32-v6 app that tries to poke around the internals (not that they

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-12 Thread Owen Rudge
You can't do that. HIMAGELIST should be the same thing as IImageList. Hmm. Looking at the HIMAGELIST/IImageList internals in a debugger on Windows, the layout appears to be entirely different to the HIMAGELIST layout defined in dlls/comctl32/imagelist.h (as you'd expect -the vtable, etc, need

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-12 Thread Nikolay Sivov
Owen Rudge wrote: --- dlls/comctl32/imagelist.c | 318 - 1 files changed, 317 insertions(+), 1 deletions(-) Hi. +/* + * IImageList implementation + */ + +typedef struct { +