Re: [DSOUND] little patch

2005-03-15 Thread Alexandre Julliard
Raphael <[EMAIL PROTECTED]> writes: > I approve :) > i would like to have a wine_dbgstr_cs() :) > > Alexandre ? I'm not sure we want to make that thing "official", it's really a nasty hack at the moment. -- Alexandre Julliard [EMAIL PROTECTED]

Re: [DSOUND] little patch

2005-03-14 Thread Raphael
> > > > This is Alexandre's trick which I borrowed because it is very helpful > > in debugging lock problems. > > It would be nice to formalize this and make it available in a more > > general way but that is Alexandre's call. Hi > Something like this plus a lot of documentation explaining what i

Re: [DSOUND] little patch

2005-03-12 Thread Robert Reif
+#define WINE_SET_CS_NAME(cs, name) (cs)->DebugInfo->Spare[1] = (DWORD) name +#define WINE_GET_CS_NAME(cs) (const char*) (cs)->lock.DebugInfo->Spare[1] This is a wine specific trick and should probably be put somewhere global so all users can be consistent. The name should have DEBUG in it

Re: [DSOUND] little patch

2005-03-12 Thread Robert Reif
Raphael wrote: - This->lock.DebugInfo->Spare[1] = 0; + /*This->lock.DebugInfo->Spare[1] = 0;*/ DeleteCriticalSection(&(This->lock)); You have to zero this out or DeleteCriticalSection will try to delete that static memory. How ? At opposite it produce DebugInfo leaks as seen in RtlDele

Re: [DSOUND] little patch

2005-03-11 Thread Raphael
Hi On Friday 11 March 2005 03:40, Robert Reif wrote: > Raphael wrote: > >Hi > > > >Changelog: > > - try to have better match caps with hw caps so games can active more hw > >support > > > >Regards, > >Raphael > > > > > > > >-This->lock.DebugInfo->Spare[1] = 0; > >+/*This->lock.DebugInfo->S

Re: [DSOUND] little patch

2005-03-10 Thread Robert Reif
Raphael wrote: Hi Changelog: - try to have better match caps with hw caps so games can active more hw support Regards, Raphael - This->lock.DebugInfo->Spare[1] = 0; + /*This->lock.DebugInfo->Spare[1] = 0;*/ DeleteCriticalSection(&(This->lock)); You have to zero this out or DeleteCriticalSe