Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On Thu, Oct 14, 2004 at 05:21:41PM +0200, Andreas Mohr wrote: >> Hi, >> >> On Thu, Oct 14, 2004 at 03:53:41PM +0100, Peter Riocreux wrote: >> > if (!(wFlags & DDF_DONTDRAW) && whdd->hpal) >> > -SelectPalette(hdc, whdd->hpal, FALSE); >>

Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Dimitrie O. Paun
On Thu, Oct 14, 2004 at 05:21:41PM +0200, Andreas Mohr wrote: > Hi, > > On Thu, Oct 14, 2004 at 03:53:41PM +0100, Peter Riocreux wrote: > > if (!(wFlags & DDF_DONTDRAW) && whdd->hpal) > > -SelectPalette(hdc, whdd->hpal, FALSE); > > + if ((wFlags & DDF_BACKGROUNDPAL) && ! (wFlags

Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Andreas Mohr
Hi, On Thu, Oct 14, 2004 at 03:53:41PM +0100, Peter Riocreux wrote: > if (!(wFlags & DDF_DONTDRAW) && whdd->hpal) > -SelectPalette(hdc, whdd->hpal, FALSE); > + if ((wFlags & DDF_BACKGROUNDPAL) && ! (wFlags & DDF_SAME_HDC)) > + SelectPalette(hdc, whdd->hpal, TRUE); > +

Re: [PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
Andreas Mohr <[EMAIL PROTECTED]> writes: > This is rather non-obvious if handling, I'm surprised that the compiler > doesn't warn about it, or does it? It did, but I was making from the top level and it got lost amongtsh the other messages. > Could you add proper braces there? Fixed up patch be

[PATCH] DrawDibDraw flag handling

2004-10-14 Thread Peter Riocreux
I got a lot of messages from this function about a particular flag (DDF_BACKGROUNDPAL) not being handled, so I tried to handle it. The MSDN docs are at I am coming to this completely cold, so I