On Sat, 2005-06-11 at 21:55 -0500, Dustin Navea wrote:
Ok, Now I am getting fed up with all this petty bickering over indent
amounts. Alexandre wants 4 space indents. As soon as I get Linux
installed on my box, I'm going to _MANUALLY_ go through every single
file and make sure that we
OHHH.. Boy do I feel a lil silly now. I was thinking it was pretty much
a steadfast rule, but that if someone felt strongly about their
indentation style, we would still accept their patch so that we could
get more functionality, and at the same time encourage them to submit
more.. Guess I
Dustin Navea wrote:
Ok, Now I am
getting fed up with all this petty bickering over indent amounts.
Alexandre wants 4 space indents. As soon as I get Linux installed on
my box, I'm going to _MANUALLY_ go through every single file and make
sure that we have 4 space indent, since I wouldnt know
On Sun, 2005-06-12 at 10:03 -0500, Mitchell Mebane wrote:
I've always wondered, why not tabs? Any decent text editor can display
tabs however wide someone wants them to be. Wouldn't that solve the
whole problem? Or is there some other problem with tabs that I'm
missing?
In fact, if editors
On 6/12/05, Dimi Paun [EMAIL PROTECTED] wrote:
-- if people mix tabs and spaces (and they do) the output is not sane
Tab is 8 spaces.
Why not go from 4-space indent as a request to a rule? And then in
the future you can simple say this is the rule of coding etiquette
here?
Tom
--
Why not a compromise, then ? I'm sure three space indents are clear
enough, but do not involve excessive typing. (IIRC, M$ and Borland both
use 3-space)
Andrew
You can be the captain
I will draw the chart
Sailing into destiny
Closer to the heart
Closer to the Heart by Rush (A Farewell to
On Sun, 2005-06-12 at 21:12 +0100, Andrew Neil Ramage wrote:
Why not a compromise, then ? I'm sure three space indents are clear
enough, but do not involve excessive typing. (IIRC, M$ and Borland
both use 3-space)
:) No, please don't. In the Wine tree we currently use 2, 4, 8 space
indents.
On Wednesday 08 June 2005 19:16, you wrote:
From: Gerold J. Wucherpfennig [EMAIL PROTECTED]
Cool stuff Gerold. A few nits:
+ if(PFCI_INT(hfci)-fNextCab==TRUE) {
It's better to avoid explicit comparison with TRUE.
What if fNextCab is 10, not 1? It's still true, but
it will fail the above
On Sat, 2005-06-11 at 16:37 +0200, Gerold J. Wucherpfennig wrote:
In my opinion BOOL is a crap and a real shortcoming
of the C programming language.
[...]
And last: if(fNextCab==TRUE) makes it more obvious for the quick
source code reader when a BOOL value is compared than if(fNextCab).
Well,
Ok, Now I am getting fed up with all this petty bickering over indent
amounts. Alexandre wants 4 space indents. As soon as I get Linux
installed on my box, I'm going to _MANUALLY_ go through every single
file and make sure that we have 4 space indent, since I wouldnt know how
to write up a
On Wednesday 08 June 2005 18:16, Dimi Paun wrote:
Also, I know you're modifying existing code, but if it's not
too much to ask, 2-space indent is hard to read, and the vast
majority of developers do prefer 4-space indent. So if you
don't mind, and we can find a solution, would be great if we
From: Gerold J. Wucherpfennig [EMAIL PROTECTED]
Cool stuff Gerold. A few nits:
+ if(PFCI_INT(hfci)-fNextCab==TRUE) {
It's better to avoid explicit comparison with TRUE.
What if fNextCab is 10, not 1? It's still true, but
it will fail the above test. Just do:
+ if(PFCI_INT(hfci)-fNextCab) {
Gerold J. Wucherpfennig [EMAIL PROTECTED] writes:
--- dlls/cabinet/cabinet.h14 May 2005 11:06:10 - 1.12
+++ dlls/cabinet/cabinet.h8 Jun 2005 14:05:42 -
@@ -89,11 +89,17 @@ typedef UINT32cab_off_t;
#define cffoldCOMPTYPE_QUANTUM (0x0002)
#define
13 matches
Mail list logo
