Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-30 Thread James McKenzie
On 12/30/10 12:48 PM, Vitaliy Margolen wrote: On 12/30/2010 12:23 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on w

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-30 Thread Vitaliy Margolen
On 12/30/2010 12:23 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. You still haven't fixed strings spanning multiple lines. Please send a patch that fixes all incorrect strings first. Then continue on with the correct style. Adding more invalid st

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-23 Thread Travis Athougies
To address, the C string literals issue, this is the same format I have used for the other test strings. It would seem inconsistent to break this now. Maybe a later patch can address this. I've used IUnknown_Release in other places to free ID3D10Blobs, so it also seems inconsistent to use ID3D10Bl

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-23 Thread Rico Schüller
Am 23.12.2010 00:37, schrieb Michael Stefaniuc: Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. --- dlls/d3dcompiler_43/tests/hlsl.c | 87 ++ 1 files changed, 87 insertion

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-22 Thread Michael Stefaniuc
Hello Travis, On 12/22/2010 10:31 PM, Travis Athougies wrote: Tests to ensure the HLSL compiler won't crash on malformed input. --- dlls/d3dcompiler_43/tests/hlsl.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/dlls/d3dcompiler