Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
2012/10/30 Hans Leidekker > On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote: > > Just by curiosity. What the difference with strncmpW? > > strncmp tests the first string for null termination. You should really > determine that by yourself though :-) > > > >> Do you have a concrete exampl

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Hans Leidekker
On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote: > Just by curiosity. What the difference with strncmpW? strncmp tests the first string for null termination. You should really determine that by yourself though :-) > >> Do you have a concrete example that does not work with this implement

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
Le 30/10/2012 09:18, Hans Leidekker a écrit : On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote: This is almost the same as your first try. You're testing a trivial case only - ASCII range. I feel like it should behave more like memcmp for case insensitive comparison, that's what document

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Hans Leidekker
On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote: > > This is almost the same as your first try. You're testing a trivial > > case only - ASCII range. > > I feel like it should behave more like memcmp for case insensitive > > comparison, > > that's what documentation mildly suggests. > >

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Nikolay Sivov
On 10/30/2012 10:42, Christian Costa wrote: Le 30/10/2012 08:21, Nikolay Sivov a écrit : On 10/30/2012 01:43, Christian Costa wrote: Try 2: - Don't use CompareStringEx. - Add tests --- dlls/kernel32/kernel32.spec |1 + dlls/kernel32/locale.c | 28 dlls/

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-30 Thread Christian Costa
Le 30/10/2012 08:21, Nikolay Sivov a écrit : On 10/30/2012 01:43, Christian Costa wrote: Try 2: - Don't use CompareStringEx. - Add tests --- dlls/kernel32/kernel32.spec |1 + dlls/kernel32/locale.c | 28 dlls/kernel32/tests/locale.c | 60 +

Re: [PATCH] kernel32: Implement CompareStringOrdinal. (try 2)

2012-10-29 Thread Nikolay Sivov
On 10/30/2012 01:43, Christian Costa wrote: Try 2: - Don't use CompareStringEx. - Add tests --- dlls/kernel32/kernel32.spec |1 + dlls/kernel32/locale.c | 28 dlls/kernel32/tests/locale.c | 60 +- 3 files changed