Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-07-04 Thread Maarten Lankhorst
Hey Joerg, 2012/6/26 joerg-cyril.hoe...@t-systems.com: Hi, If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. I won't

[PATCH] winepulse.drv: Add PulseAudio driver

2012-06-26 Thread Joerg-Cyril.Hoehle
Hi, If you don't paste all the mmdevapi tests with the fix in my git tree, it's a regression. I don't want to see held_Frames because it's a shadow buffer. If winmm and dsound don't work without it, they're wrong, fix those. I won't comment on the two individual pulseaudio drivers.

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-19 Thread Darryl Slack
Well after fighting with pulseaudio after all this time I have tried this patch with wine 1.5.6 with a Presonus StudioLive 24.4.2 Fire-wire controller within wine, to control software known as Virtual DJ with timecoded vinyl records. With Andrew's patch, there are stalled buffer errors, and I

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Fri, Jun 15, 2012 at 06:23:57PM -0700, Chris Robinson wrote: The update_size is only relevant if mmdevapi updates in period-sized chunks. If it doesn't, you can just remove it and the rounding. The tlength should be kept updated using pa_stream_set_buffer_attr_callback, in case the server

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Chris Robinson
On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: We chatted a little on IRC this weekend, but thanks again for the advice. No problem. :) Mmdevapi sends it data to the lower systems in period-sized chunks, and the reported buffer fill level decreases in period-sized chunks. But the

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-18 Thread Andrew Eikum
On Mon, Jun 18, 2012 at 08:49:55AM -0700, Chris Robinson wrote: On Monday, June 18, 2012 9:31:04 AM Andrew Eikum wrote: Yeah, I experimented with ADJUST_LATENCY, as it seems to be the trick to getting lower latencies. Then we have to maintain our own buffer, which is why I switched to using

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-16 Thread Maarten Lankhorst
What happened to the stamped capture buffers? Why is held_frames added? This doesn't look like an attempt to get my driver in, it looks like a rewrite by someone who doesn't understand why I made the design decisions I made for correctness. If you don't paste all the mmdevapi tests with the fix

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-11 Thread Alexandre Julliard
Andrew Eikum aei...@codeweavers.com writes: There's a lengthy comment in ready_pulse() describing why we're using pthreads syncro primitives instead of Win32 primitives. I was under the impression (thanks to the CoreAudio driver, mostly) that threads not created through CreateThread() cannot

Re: [PATCH] winepulse.drv: Add PulseAudio driver

2012-06-10 Thread Dmitry Timoshkov
Andrew Eikum aei...@codeweavers.com wrote: configure.ac | 31 +- dlls/mmdevapi/main.c |4 +- dlls/winepulse.drv/Makefile.in|9 + dlls/winepulse.drv/mmdevdrv.c | 3216 +