re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

2013-05-29 Thread Maarten Lankhorst
NAK. + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning primary_pwfx to NULL? ~Maarten

Re: [PATCH (try 2)] dsound: Copy SetFormat format more directly if we're not in PRIMARYWRITE mode

2013-05-29 Thread Andrew Eikum
On Wed, May 29, 2013 at 01:10:56PM +0200, Maarten Lankhorst wrote: > NAK. > > + HeapFree(GetProcessHeap(), 0, device->primary_pwfx); > + device->primary_pwfx = DSOUND_CopyFormat(passed_fmt); > Copy to a tmp buffer first and return E_OUTOFMEMORY instead of reassigning > pri