Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-04 Thread GOUJON Alexandre
On 08/04/2010 12:29 PM, Alexandre Julliard wrote: You can't use Wine exception macros in tests. I guess my patch [1] was rejected for the same reason but then how to handle it ? The test only crashes on NT4 but is needed because some programs use a NULL descriptor [2] I'm not allowed

Re: Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-04 Thread Oldrich Jedlicka
Hi Stefan, 4.8.2010 13:04:43, Stefan Dösinger : > > Am 04.08.2010 um 12:29 schrieb Alexandre Julliard: > > > Oldřich Jedlička writes: > > > >> +__TRY > >> +{ > >> +hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL); > >> +todo_wine ok(hr == DDERR_INVALIDPARAMS, "ID

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-04 Thread Stefan Dösinger
Am 04.08.2010 um 12:29 schrieb Alexandre Julliard: > Oldřich Jedlička writes: > >> +__TRY >> +{ >> +hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL); >> +todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface >> didn't return 0x%08x, but 0x%08x\n", >>

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-04 Thread Alexandre Julliard
Oldřich Jedlička writes: > +__TRY > +{ > +hr = IDirectDraw_CreateSurface(lpDD, NULL, &surf, NULL); > +todo_wine ok(hr == DDERR_INVALIDPARAMS, "IDirectDraw_CreateSurface > didn't return 0x%08x, but 0x%08x\n", > + DDERR_INVALIDPARAMS, hr); > +} > +__EXCEPT

Re: [PATCH 03/10] ddraw/tests: Add test for NULL/bad size of surface caps in CreateSurface. (try 3)

2010-08-03 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4250 Your paranoid android.