Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Paul Vriens
Giuseppe Bilotta wrote: Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. --- dlls/comctl32/tests/toolbar.c | 51 + 1 files changed, 51 insertions(+), 0 deletions(-) Hi

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Mikołaj Zalewski
Hi, I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. +static void test_deadbeef(void) I think you should find a better name. Maybe

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Paul Vriens
Giuseppe Bilotta wrote: On Thu, Apr 23, 2009 at 8:00 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Giuseppe Bilotta wrote: Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. Patches should only go to wine-patches

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
On Thu, Apr 23, 2009 at 8:00 AM, Paul Vriens paul.vriens.w...@gmail.com wrote: Giuseppe Bilotta wrote: Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. Patches should only go to wine-patches unless you'd like them

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski miko...@zalewski.pl:  Hi,  I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. You're definitely on to something here.

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Paul Vriens
Giuseppe Bilotta wrote: 2009/4/23 Mikołaj Zalewski miko...@zalewski.pl: Hi, I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. You're definitely on

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski miko...@zalewski.pl:  Hi,  I think it would be interesting to test what TB_GETBUTTONINFO returns as iString for such a separator. That way we will know if the value is simply ignored, or it's something more complicated. Forget what I said in my previous email. I was

[PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-22 Thread Giuseppe Bilotta
Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. --- dlls/comctl32/tests/toolbar.c | 51 + 1 files changed, 51 insertions(+), 0 deletions(-) diff --git