[PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

2011-09-08 Thread Joerg-Cyril . Hoehle
Andrew Eikum asked: >It would be nice to have tests for this, >Are these part of the tests you're >planning on submitting after you get the fixes in? That is part of my tests, the latest testbot job is https://testbot.winehq.org/JobDetails.pl?Key=14067 You can see that I still need to compute posit

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

2011-09-08 Thread Octavian Voicu
On Thu, Sep 8, 2011 at 6:37 PM, Octavian Voicu wrote: > You are dereferencing 'closest' without checking if it's non-NULL. It > can be NULL if control jumps to the 'exit' label for several cases. > This only applies to winealsa; for wineoss there are no gotos. Disregard that, I see now that hr is

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

2011-09-08 Thread Octavian Voicu
--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c> @@ -1310,17 +1313,14 @@ exit: > LeaveCriticalSection(&This->lock); > HeapFree(GetProcessHeap(), 0, formats); > > -if(hr == S_OK || !out){ > -CoTaskMemFree(closest); > -if(out) > -*out = N

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

2011-09-08 Thread Andrew Eikum
It would be nice to have tests for this, and a fix for coreaudio if needed. Likewise for patch 2/2. Are these part of the tests you're planning on submitting after you get the fixes in? Andrew On Thu, Sep 08, 2011 at 04:09:37PM +0200, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > Wine is cu