Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Michael Karcher
Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov: The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3. These should be 2 separate

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Dmitry Timoshkov
Michael Karcher w...@mkarcher.dialup.fu-berlin.de wrote: And according to http://test.winehq.org/data/e2af560aa3c23a672d8680f91f3e1b8793d5827f/index_XP.html#user32:win SetParent tests pass under XP just fine. No, they don't pass on Windows XP. But they also don't fail on Windows XP,

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Paul Vriens
On 01/25/2010 09:37 AM, Michael Karcher wrote: Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov: The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Paul Vriens
On 01/25/2010 11:30 AM, Michael Karcher wrote: Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens: On 01/25/2010 09:37 AM, Michael Karcher wrote: Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov: The current code misdetects both Windows XP and Wine as Win9x and skips

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Michael Karcher
Am Montag, den 25.01.2010, 10:47 +0100 schrieb Paul Vriens: On 01/25/2010 09:37 AM, Michael Karcher wrote: Am Montag, den 25.01.2010, 15:27 +0800 schrieb Dmitry Timoshkov: The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-25 Thread Michael Karcher
Am Montag, den 25.01.2010, 12:49 +0100 schrieb Paul Vriens: It shows only lines 3236 to 3250 being run - these are the tests that are not protected by the broken is_win9x check. So are all these checks broken according to you or just specific ones? The patch that started this thread

Re: [PATCH 1/2] user32/tests/win.c: Fix Win9x detection

2010-01-24 Thread Dmitry Timoshkov
Michael Karcher w...@mkarcher.dialup.fu-berlin.de wrote: The current code misdetects both Windows XP and Wine as Win9x and skips some tests due to this. The SetParent tests were not passing on XP, so this patch also removes the tests that fail on XP SP3. These should be 2 separate patches.