Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.

2012-06-19 Thread André Hentschel
Am 19.06.2012 03:09, schrieb Erich E. Hoover: > On Mon, Jun 18, 2012 at 3:26 PM, André Hentschel wrote: >> Am 18.06.2012 15:52, schrieb Erich E. Hoover: >> ... >>> Changelog: >>> hhctrl.ocx: Add HTML to Unicode decoding capability. >> >> You're adding dead code here, you should maybe merge Pat

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.

2012-06-18 Thread Erich E. Hoover
On Mon, Jun 18, 2012 at 3:26 PM, André Hentschel wrote: > Am 18.06.2012 15:52, schrieb Erich E. Hoover: > ... > > Changelog: > >     hhctrl.ocx: Add HTML to Unicode decoding capability. > > You're adding dead code here, you should maybe merge Patch 1 & 2 Since part 2 and 3 are both dependent upon

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability.

2012-06-18 Thread André Hentschel
Am 18.06.2012 15:52, schrieb Erich E. Hoover: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for >

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-15 Thread Alexandre Julliard
"Erich E. Hoover" writes: > +while(min <= max) > +{ > +const char *encoded_symbol; > + > +pos = (min+max)/2; > +encoded_symbol = html_encoded_symbols[pos].html_code; > +dir = strncmp(encoded_symbol, amp, len);

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:47 AM, Erich E. Hoover wrote: > ... > I can't think of any other way they'd be doing it...  It honestly blew > me away to see that screenshot, I wouldn't have thought to implement > it that way in a million years. The bug submitter was using xchm, so for completeness I

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:44 AM, Alexandre Julliard wrote: > ... > Wow, is Windows really doing it this way?  That's a good contestant for > the Most Stupid Win32 API Behavior award. I can't think of any other way they'd be doing it... It honestly blew me away to see that screenshot, I wouldn't

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Erich E. Hoover
On Thu, Jun 14, 2012 at 11:22 AM, Alexandre Julliard wrote: > ... > > I don't see why you'd want to use ANSI code pages for this, since they > will be converted to Unicode anyway. It's important to use the ANSI code page because of the way the characters are handled internally (you can see this i

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Alexandre Julliard
"Erich E. Hoover" writes: > On Thu, Jun 14, 2012 at 11:22 AM, Alexandre Julliard > wrote: >> ... >> >> I don't see why you'd want to use ANSI code pages for this, since they >> will be converted to Unicode anyway. > > It's important to use the ANSI code page because of the way the > characters a

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 4).

2012-06-14 Thread Alexandre Julliard
"Erich E. Hoover" writes: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index for > displaying internat

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 3).

2012-06-13 Thread Jacek Caban
Hi Erich, On 06/12/12 19:03, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).

2012-06-12 Thread Erich E. Hoover
On Tue, Jun 12, 2012 at 2:07 AM, Jacek Caban wrote: > ... > You didn't address most of my comments. Feel free to ask for > clarifications if something was not clear enough. I'm really sorry about that, for some reason gmail hid them as a quote. Erich

Re: [PATCH 1/4] hhctrl.ocx: Add HTML to Unicode decoding capability (try 2).

2012-06-12 Thread Jacek Caban
Hi Erich, On 06/11/12 21:01, Erich E. Hoover wrote: > Real Name: > Erich Hoover > > Description: > This patch adds the ability in HTML Help to convert HTML encoded > characters (e.g. ê) into the Unicode character equivalent. This > feature is needed by the table of contents and the index