Re: [PATCH 1/5] mmdevapi: Add InitializeDriver() method to drivers

2011-05-02 Thread Alexandre Julliard
Paul Chitescu writes: > Wine is already plagued by deadlocks in the MM drivers initialization that > interfere with the loader's lock. Explicit initialization after LoadLibrary > returns should help getting rid of these. Considering that the MM drivers don't implement DLL_PROCESS_ATTACH at all

Re: [PATCH 1/5] mmdevapi: Add InitializeDriver() method to drivers

2011-05-02 Thread Paul Chitescu
On Monday 02 May 2011 01:32:59 pm Alexandre Julliard wrote: > Andrew Eikum writes: > > @@ -72,11 +73,19 @@ static BOOL load_driver(const WCHAR *name) > > } > > > > #define LDFC(n) do { drvs.p##n = (void*)GetProcAddress(drvs.module, > > #n);\ -if(!drvs.p##n) return FALSE; } while(0);

Re: [PATCH 1/5] mmdevapi: Add InitializeDriver() method to drivers

2011-05-02 Thread Alexandre Julliard
Andrew Eikum writes: > @@ -72,11 +73,19 @@ static BOOL load_driver(const WCHAR *name) > } > > #define LDFC(n) do { drvs.p##n = (void*)GetProcAddress(drvs.module, #n);\ > -if(!drvs.p##n) return FALSE; } while(0); > +if(!drvs.p##n) { FreeLibrary(drvs.module); return FALSE; }