Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 00:15, schrieb Henri Verbeet: -swapchain-swapchain_ops-swapchain_present(swapchain, src_rect, dst_rect, dirty_region, flags); + wined3d_cs_emit_present(swapchain-device-cs, swapchain, src_rect, +dst_rect,

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 13:05, Stefan Dösinger stefandoesin...@gmail.com wrote: I think we should place comments like This function is called through the command stream for all functions that are called through the CS, similar to what we do for context activation. Perhaps, I'm not sure. For that

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it has that until we work out the details of the multi-threaded implementation.

Re: [PATCH 1/5] wined3d: Send present operations through a command stream.

2013-09-27 Thread Henri Verbeet
On 27 September 2013 15:23, Stefan Dösinger stefandoesin...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-27 14:19, schrieb Henri Verbeet: Perhaps, I'm not sure. For that kind of comment to be useful it should have a clear set of implications, and I'm not sure it