Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-25 Thread Misha Koshelev
On 24 June 2010 05:18, Misha Koshelev misha680 at gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-25 Thread Henri Verbeet
On 25 June 2010 18:20, Misha Koshelev misha...@gmail.com wrote: regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *. Oh and the LPDIRECT3DDEVICE9's are straight from line.c tests.

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-25 Thread Misha Koshelev
On Fri, 2010-06-25 at 18:59 +0200, Henri Verbeet wrote: On 25 June 2010 18:20, Misha Koshelev misha...@gmail.com wrote: regard, although there are (very) minor issues like using %d for unsigned arguments and using imo ugly typedefs like LPDIRECT3DDEVICE9 over simply IDirect3DDevice9 *.

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread Henri Verbeet
On 24 June 2010 05:18, Misha Koshelev misha...@gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the advice

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread Misha Koshelev
On 24 June 2010 05:18, Misha Koshelev misha680 at gmail.com wrote: Dan suggested tests ok during code freeze so blame Dan for my patches ;) Certainly will. wine-devel is an open mailing list, and posting is easy. You'll probably want to check with something like git shortlog -s -n if the

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread Henri Verbeet
On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: http://source.winehq.org/patches/, you'll see 62909 is marked as Deferred, so resending in a slightly different form isn't going to help much. Ah I see thank you. I take it this means deferred until post-code freeze (please

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread James Mckenzie
Henri Verbeet hverb...@gmail.com wrote: On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone bugs for now and see if I can help. Yeah, milestone bugs

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-24 Thread Misha Koshelev
On Thu, 2010-06-24 at 11:33 -0700, James Mckenzie wrote: Henri Verbeet hverb...@gmail.com wrote: On 24 June 2010 18:11, Misha Koshelev misha...@gmail.com wrote: Ok thank you. Since we are in code freeze and I'd like to help wine, perhaps then I will just go down the list of 1.2 milestone

Re: [PATCH 1/7] d3dx9: Shape functions in own file, add stub and basic tests for D3DXCreateSphere.

2010-06-23 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2885 Your paranoid