Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)

2013-04-01 Thread Sam Edwards
On 04/01/2013 08:16 AM, Henri Verbeet wrote: I think it's ok for the tests to be todo_wine, but we do want ddraw coverage for this in the tests. Fine by me. But that will take a few days since I'll have to familiarize myself with ddraw first. :) In the meantime, should I resend this patchset

Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)

2013-04-01 Thread Henri Verbeet
On 1 April 2013 16:56, Sam Edwards wrote: > In the meantime, should I resend this patchset (with the reset_device() > change included) so that it can be reviewed and committed while I'm busy > with ddraw (and send the ddraw tests in a separate patch), or is this > patchset unacceptable until I inc

Re: [PATCH 3/4] d3d9/tests: Verify window style after exiting fullscreen mode. (try 2)

2013-04-01 Thread Henri Verbeet
On 1 April 2013 02:40, Sam Edwards wrote: > I opted not to write ddraw tests. The existing ddraw window style tests > suggest that DirectDraw doesn't even set WS_VISIBLE when initializing a > (non-visible) window, which is very odd, so any new tests would have been > todo_wine anyway. Nonetheless,