Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx

2012-11-13 Thread Maarten Lankhorst
Hey, Op 19-10-12 15:29, Andrew Eikum schreef: > Patches 1 and 2 in this series look fine. > > I have a series of patches similar to this one in my dsound > multichannel branch. This patch seems to do too much at once. > > When I did this cleanup, I split it up into four patches: > 1) Allocate the

Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx

2012-10-22 Thread Andrew Eikum
On Sat, Oct 20, 2012 at 12:13:08AM +0200, Maarten Lankhorst wrote: > Hey, > > Op 19-10-12 15:29, Andrew Eikum schreef: > > Patches 1 and 2 in this series look fine. > > > > I have a series of patches similar to this one in my dsound > > multichannel branch. This patch seems to do too much at once.

Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx

2012-10-19 Thread Maarten Lankhorst
Hey, Op 19-10-12 15:29, Andrew Eikum schreef: > Patches 1 and 2 in this series look fine. > > I have a series of patches similar to this one in my dsound > multichannel branch. This patch seems to do too much at once. > > When I did this cleanup, I split it up into four patches: > 1) Allocate the

Re: [PATCH 3/6] dsound: create a primary_pwfx separately from pwfx

2012-10-19 Thread Andrew Eikum
Patches 1 and 2 in this series look fine. I have a series of patches similar to this one in my dsound multichannel branch. This patch seems to do too much at once. When I did this cleanup, I split it up into four patches: 1) Allocate the device format in the Device struct 2) Load the default form