Re: [PATCH 4/6] [cmd] Add for /f parsingkeyword parsing, add support for skip=

2012-10-17 Thread Alexandre Julliard
Ann and Jason Edmeades ja...@edmeades.me.uk writes: Parse the options you can provide with for /f to control the subsequent parsing, and add support for the simplest (skip). @@ -1546,6 +1545,13 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) { intitemNum; CMD_LIST *thisCmdStart;

Re: [PATCH 4/6] [cmd] Add for /f parsingkeyword parsing, add support for skip=

2012-10-17 Thread Ann and Jason Edmeades
It's clearly time to start splitting WCMD_for into several helper functions. I completely agree, and it was definitely on my radar to do... its really ugly code in there (I take responsibility for a lot of that!) as it has been a slow incremental increase in what we actually supported... I was

re: [PATCH 4/6] [cmd] Add for /f parsingkeyword parsing, add support for skip=

2012-10-17 Thread Dan Kegel
Jason wrote: It's clearly time to start splitting WCMD_for into several helper functions. I completely agree, and it was definitely on my radar to do... its really ugly code in there (I take responsibility for a lot of that!) as it has been a slow incremental increase in what we actually