[PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Joerg-Cyril . Hoehle
Hi, Michael Stefaniuc wrote: static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer +if (pUnk) { +WARN(invalid parameter: pUnk != NULL\n); +/* *lplpDSCaptureBuffer = NULL; Not done by native dsound */ +return DSERR_NOAGGREGATION; +} What's your

Re: [PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: Hi, Michael Stefaniuc wrote: static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer +if (pUnk) { +WARN(invalid parameter: pUnk != NULL\n); +/* *lplpDSCaptureBuffer = NULL; Not done by native dsound */ +return

Re: [PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Michael Stefaniuc
Hello Joerg, and addendum inline Michael Stefaniuc wrote: joerg-cyril.hoe...@t-systems.com wrote: Michael Stefaniuc wrote: static HRESULT WINAPI IDirectSoundCaptureImpl_CreateCaptureBuffer +if (pUnk) { +WARN(invalid parameter: pUnk != NULL\n); +/* *lplpDSCaptureBuffer =

Re: [PATCH 5/8] dsound: Make capture behave like native in regards to COM aggregation.

2012-01-12 Thread Alexandre Julliard
Michael Stefaniuc mstef...@redhat.com writes: Now i would have had different options how to deal with that. - Silently drop the test. - Dropping the test and documenting why it deviates from the standard test. - Adding the test and marking it todo_wine. - Add the test and fix the code as the