Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-24 Thread Eric Pouech
Jason Green a écrit : > On Jan 23, 2008 3:38 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > >> Jason Green a écrit : >> thanks for the sample files >> how does this patch solve the issue ? >> A+ >> >> diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h >> index 58627c0..8a22dfd 100644 >>

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-24 Thread Jason Green
On Jan 23, 2008 3:38 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > Jason Green a écrit : > thanks for the sample files > how does this patch solve the issue ? > A+ > > diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h > index 58627c0..8a22dfd 100644 > --- a/include/wine/mscvpdb.h > +++ b/

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-23 Thread Eric Pouech
Jason Green a écrit : thanks for the sample files how does this patch solve the issue ? A+ diff --git a/include/wine/mscvpdb.h b/include/wine/mscvpdb.h index 58627c0..8a22dfd 100644 --- a/include/wine/mscvpdb.h +++ b/include/wine/mscvpdb.h @@ -343,9 +343,9 @@ union codeview_type { un

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-23 Thread Jason Green
See the first paragraph: :) Re-re-responses from Eric van Beurden. I'll send the sample app to you off-list (and anyone else who wants a copy, just email me directly).: I'll send it to you off-list, too, John. On Jan 23, 2008 10:31 AM, John Klehm <[EMAIL PROTECTED]> wrote: > On Jan 23, 2008

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-23 Thread John Klehm
On Jan 23, 2008 8:14 AM, Jason Green <[EMAIL PROTECTED]> wrote: > > The attached archive contains 4 files: > - 'emptyTest.exe': the optimized release build executable linked to > 'emptyTest.pdb'. This should crash. > - 'emptyTest.pdb': the PDB file > - 'main.cpp': the source file for the test app.

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-23 Thread Jason Green
On Jan 22, 2008 4:00 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > Jason Green a écrit : > > Re-responses from Eric van Beurden: > > > > > >> hmm I still don't get how, in a generic way symbols could overlap > >> the only think I could come up with if when static functions get > >> automatically inl

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-22 Thread Jason Green
Re-responses from Eric van Beurden: > hmm I still don't get how, in a generic way symbols could overlap > the only think I could come up with if when static functions get > automatically inlined by the compiler, but that's rather a different > story (as I'd suspect the inlined function to be a sin

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-21 Thread Eric Pouech
Jason Green a écrit : > Eric, below are the responses from Eric van Beurden, who wrote the > patch. I merely split it up and removed a bunch of traces for > submission to WineHQ. The problem is that all of our changes were > done initially in just a couple of huge commits during the initial > imp

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-21 Thread Jason Green
Eric, below are the responses from Eric van Beurden, who wrote the patch. I merely split it up and removed a bunch of traces for submission to WineHQ. The problem is that all of our changes were done initially in just a couple of huge commits during the initial import of dbghelp instead of nice,

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-18 Thread Eric Pouech
Jason Green a écrit : > > > From 14d91ebd5974c8fc02f8b83d53e8eff0df7ad76d Mon Sep 17 00:00:00 2001 > From: Jason Green <[EMAIL PROTECTED](none)> > Date: Thu, 17 Jan 2008 16:41:11 -0500 > Subject: [PATCH] Rewrite much of the sy

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well

2008-01-18 Thread Alexandre Julliard
"Jason Green" <[EMAIL PROTECTED]> writes: > + > +#ifdef TRACE_SYMBOL_LIST > +TRACE("\n\n* sorting the table {count = %d}\n\n", > module->num_sorttab); > +#endif > + > +qsort(module->addr_sorttab, module->num_sorttab, sizeof(struct > symbol_entry), symt_cmp_addr_and_size); > + > +