Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-08 Thread Juan Lang
Hi Dan, You get a +1 from me on this one. Small note: +if (io-Information == FILE_CREATED) { +/* FIXME: is this an extra server round trip? */ (snip) +status = server_get_unix_fd( *handle, FILE_WRITE_DATA, fd, needs_close, NULL, NULL ); It is, but for most file

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-06 Thread Dan Kegel
On Sun, Oct 4, 2009 at 9:21 AM, Juan Lang juan.l...@gmail.com wrote: +    TRACE(fd %d, name %s, attrib %x\n, fd, debugstr_a(unix_fname), *pattrib); +    *pattrib = attributes; Any reason you're tracing *pattrib before you set it? Fixed, thanks! + * If unix_fname is not NULL,

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-04 Thread Juan Lang
Hi Dan, in patch 2/3, +TRACE(fd %d, name %s, attrib %x\n, fd, debugstr_a(unix_fname), *pattrib); +*pattrib = attributes; Any reason you're tracing *pattrib before you set it? + * If unix_fname is not NULL, DIR_is_hidden_file is called to do .dotfile check This is a change from the

Re: [ntdll] Move file attribute logic to new function DIR_get_attributes()

2009-10-02 Thread Dan Kegel
http://bugs.winehq.org/show_bug.cgi?id=15679 has the latest draft of the patch. AJ's probably getting tired of reviewing it over and over again, so if anyone else can do a quick review I'd appreciate it. I'll probably send it in Sunday evening