On Fri, Feb 6, 2009 at 12:35 PM, Juan Lang wrote:
> Hi Luke,
>
> @@ -382,7 +382,14 @@ static int rpcrt4_conn_np_read(RpcConnection *Connection,
> Style nit: it would be simpler to do:
> DWORD bytes_read;
> ret = ReadFile(npc->pipe, buf, bytes_left, &bytes_read, NULL);
> +if (!ret &&
Hi Luke,
@@ -382,7 +382,14 @@ static int rpcrt4_conn_np_read(RpcConnection *Connection,
{
DWORD bytes_read;
ret = ReadFile(npc->pipe, buf, bytes_left, &bytes_read, NULL);
-if (!ret || !bytes_read)
+if (!ret)
+{
+ TRACE("ReadFile error, status %x\n", GetLastError());
+
On Fri, Feb 6, 2009 at 10:29 AM, Rob Shearman wrote:
> 2009/2/5 Luke Kenneth Casson Leighton :
>> http://bugs.winehq.org/show_bug.cgi?id=17263
>
> The patch looks acceptable in theory. Please email the patch to
> wine-patches (or wine-devel) and I'll review the implementation of it.
ok!
2009/2/5 Luke Kenneth Casson Leighton :
> http://bugs.winehq.org/show_bug.cgi?id=17263
The patch looks acceptable in theory. Please email the patch to
wine-patches (or wine-devel) and I'll review the implementation of it.
--
Rob Shearman
http://bugs.winehq.org/show_bug.cgi?id=17263
hooray! very simple fix, here - allow ERROR_MORE_DATA status code as
an acceptable error.
... and _check it_, afterwards.
ideally, the loop to read a complete PDU should be vaguely like this:
do {
RpcConnection conn->ops->read(data, &len)
to
