Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-25 Thread Kirill K. Smirnov
Now, I am writing tests for this. Windows crashes if I pass NULL pointer to these function. Crash can be easily avoided in wine. Should we crash too? And how the windows crash can be caught? Or just I should not write such test-case? Thanks, -- Kirill

[try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? Thanks -- Kirill

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/24/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote: Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? You haven't sent in any tests for this function. Is

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
On 4/24/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote: Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong with it? You haven't sent in any tests for this function.

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread James Hawkins
On 4/25/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote: On 4/24/07, Kirill K. Smirnov [EMAIL PROTECTED] wrote: Hi, I've sent the patch: http://www.winehq.com/pipermail/wine-patches/2007-April/038205.html about a week ago and it has not been applied. Please, explain, what is wrong

Re: [try2] kernel32: Add partial stub for NeedCurrentDirectoryForExePath - what's wrong?

2007-04-24 Thread Kirill K. Smirnov
For containing backshash. Yes, comment must be better. A comment that states you're looking for a backslash is superfluous; the code makes that obvious. A better comment would be 'check for filename only' or something along those lines. Maybe, 'MSDN claims that if filename contains