Re: ntdll: resend 1/4 NtCreateMailslotFile tests

2007-02-27 Thread Alexandre Julliard
Jeff Latimer [EMAIL PROTECTED] writes: diff --git a/dlls/ntdll/tests/Makefile.in b/dlls/ntdll/tests/Makefile.in index 4c5..4ceccfd 100644 --- a/dlls/ntdll/tests/Makefile.in +++ b/dlls/ntdll/tests/Makefile.in @@ -14,6 +14,7 @@ CTESTS = \ generated.c \ info.c \

Re: 1/4 NtCreateMailslotFile tests

2007-02-19 Thread Jeff L
[EMAIL PROTECTED] wrote: Microsoft appears to be pushing people away from NtClose. I'd suggest you to find a reason why. That particular documentation happens to be part of the API released under court order. They didn't want to give it out to begin with, and they don't want people using it

Re: Resend 1/4 NtCreateMailslotFile tests

2007-02-19 Thread Eric Pouech
[EMAIL PROTECTED] a écrit : On 2/17/07, Eric Pouech [EMAIL PROTECTED] wrote: Jeff L a écrit : Eric Pouech wrote: Jeff Latimer a écrit : Establish the framework for testing NtCreateMailslotFile. Have fixed issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not

Re: 1/4 NtCreateMailslotFile tests

2007-02-18 Thread [EMAIL PROTECTED]
Microsoft appears to be pushing people away from NtClose. I'd suggest you to find a reason why. That particular documentation happens to be part of the API released under court order. They didn't want to give it out to begin with, and they don't want people using it now. Perhaps someone

Re: Resend 1/4 NtCreateMailslotFile tests

2007-02-18 Thread [EMAIL PROTECTED]
On 2/17/07, Eric Pouech [EMAIL PROTECTED] wrote: Jeff L a écrit : Eric Pouech wrote: Jeff Latimer a écrit : Establish the framework for testing NtCreateMailslotFile. Have fixed issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is

Re: 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Jeff L
Dmitry Timoshkov wrote: Jeff Latimer [EMAIL PROTECTED] wrote: +ok( CloseHandle(hslot), CloseHandle failed\n); To close the handle returned by an NT API you have you use an NT API as well. Have reread MSDN http://msdn2.microsoft.com/en-us/library/ms648410.aspx and it seems that NtClose has

Re: 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Jeff L
Dmitry Timoshkov wrote: Jeff L [EMAIL PROTECTED] wrote: To close the handle returned by an NT API you have you use an NT API as well. What is not apparent in the explanation above? I have no problem with what you have said though I did have a bit of difficulty marrying to the sentence

Re: Resend 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Eric Pouech
Jeff Latimer a écrit : Establish the framework for testing NtCreateMailslotFile. Have fixed issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is for ntdll functions, it shouldn't use kernel32 ones... hence, NtClose should be used

Re: Resend 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Jeff L
Eric Pouech wrote: Jeff Latimer a écrit : Establish the framework for testing NtCreateMailslotFile. Have fixed issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is for ntdll functions, it shouldn't use kernel32 ones... hence, NtClose

Re: 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Dmitry Timoshkov
Jeff L [EMAIL PROTECTED] wrote: Have reread MSDN http://msdn2.microsoft.com/en-us/library/ms648410.aspx and it seems that NtClose has been superseded by CloseHandle. So I suppose that CloseHandle is the one to use. The information in MSDN is misleading in this case, CloseHandle is a

Re: Resend 1/4 NtCreateMailslotFile tests

2007-02-17 Thread Eric Pouech
Jeff L a écrit : Eric Pouech wrote: Jeff Latimer a écrit : Establish the framework for testing NtCreateMailslotFile. Have fixed issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is for ntdll functions, it shouldn't use kernel32

Re: 1/4 NtCreateMailslotFile tests

2007-02-11 Thread Dmitry Timoshkov
Jeff Latimer [EMAIL PROTECTED] wrote: +rc = pNtCreateMailslotFile(hslot, DesiredAccess, + attr, IoStatusBlock, CreateOptions, MailslotQuota, MaxMessageSize, + TimeOut); +ok( rc == S_OK, Create MailslotFile failed rc = %x %u\n, rc, GetLastError()); NT APIs return