re: BSTR caching

2009-10-09 Thread Dan Kegel
Hi Markus, Wine development is driven by test cases checked in to the Wine source tree. Please extend the test cases in dlls/oleaut32/tests to verify that oleaut32 is caching BSTRs properly, and make sure that test passes on Windows and is marked todo_wine. Once we have a test case like that

BSTR caching

2009-10-08 Thread Markus Stockhausen
Hi, the last week I took some time to implement the first try of BSTR caching in oleaut.c. On the one hand this will fix a bug, on the other hand Wine could save some CPU cycles and can catch up with the speed of the native implementation. Attached you will find the result of my considerations

Re: BSTR caching

2009-10-08 Thread Henri Verbeet
2009/10/8 Markus Stockhausen markus.stockhau...@collogia.de: Hi, the last week I took some time to implement the first try of BSTR caching in oleaut.c. On the one hand this will fix a bug, on the other hand Wine could save some CPU cycles and can catch up with the speed of the native

Re: BSTR caching

2009-10-08 Thread Nikolay Sivov
Markus Stockhausen wrote: Hi, the last week I took some time to implement the first try of BSTR caching in oleaut.c. On the one hand this will fix a bug, on the other hand Wine could save some CPU cycles and can catch up with the speed of the native implementation. + * Windows standard

Re: BSTR caching

2009-10-08 Thread Markus Stockhausen
I'm not sure about the exact details of what this should fix, but wouldn't using a private heap have mostly the same effect? Hi Henri, it will definitely fix bug 12460 (self tested) and maybe 3756 as it implements deferred release of BSTR memory. It does not matter if we are using private heap

Re: BSTR caching

2009-10-08 Thread Markus Stockhausen
Am Donnerstag, den 08.10.2009, 18:26 +0400 schrieb Nikolay Sivov: Markus Stockhausen wrote: Hi, the last week I took some time to implement the first try of BSTR caching in oleaut.c. On the one hand this will fix a bug, on the other hand Wine could save some CPU cycles and can catch up

Re: BSTR caching

2009-10-08 Thread Alexandre Julliard
Markus Stockhausen markus.stockhau...@collogia.de writes: only the result of solving bug 12460, debugging a few testcases that produce IMalloc log entries and in this way indirectly reflect the behaviour of native oleaut (at least XP version). You should not be looking at the internal

Re: BSTR caching

2009-10-08 Thread Markus Stockhausen
You should not be looking at the internal behavior of native, only at the external behavior as observed through test cases. Hm, I know, that testcase - windows oleaut - wine ifs.c IMalloc logging is quite strange testing. Sadly this was the only way to explore the reason for not