Re: CRYPT32/tests: don't crash on win98

2005-11-14 Thread Saulius Krasuckas
* On Mon, 14 Nov 2005, Jakob Eriksson wrote: * Saulius Krasuckas wrote: isNT should be set by testing real behaviour of API, not by using GetVersion(). The recommended thing to do is check for something that can hint of bad things to happen. Yes, plus that something and

Re: CRYPT32/tests: don't crash on win98

2005-11-14 Thread Saulius Krasuckas
* On Mon, 14 Nov 2005, Saulius Krasuckas wrote: * On Mon, 14 Nov 2005, Jakob Eriksson wrote: * Saulius Krasuckas wrote: isNT should be set by testing real behaviour of API, not by using GetVersion(). The recommended thing to do is check for something that can hint of bad

Re: CRYPT32/tests: don't crash on win98

2005-11-14 Thread Jakob Eriksson
Saulius Krasuckas wrote: AFAIR, he or someone else told me that isNT should be set by testing real behaviour of API, not by using GetVersion(). As the behaviour difference materializes itself in a shape of unhandled exception, we should catch it. Are we able do it in Wine easily? I think

Test framework RFC (Was: Re: CRYPT32/tests: don't crash on win98)

2005-11-14 Thread Jakob Eriksson
Saulius Krasuckas wrote: * On Mon, 14 Nov 2005, Jakob Eriksson wrote: * Saulius Krasuckas wrote: isNT should be set by testing real behaviour of API, not by using GetVersion(). The recommended thing to do is check for something that can hint of bad things to happen.

Re: CRYPT32/tests: don't crash on win98

2005-11-13 Thread James Hawkins
On 11/13/05, Saulius Krasuckas [EMAIL PROTECTED] wrote: As far as we cannot handle exceptions in wine tests easily, this is the only way to make it running successfully. Is there no way to check what version we're running, and only run these if the version is greather than win98? This patch

Re: CRYPT32/tests: don't crash on win98

2005-11-13 Thread Saulius Krasuckas
* On Sun, 13 Nov 2005, James Hawkins wrote: * On 11/13/05, Saulius Krasuckas [EMAIL PROTECTED] wrote: As far as we cannot handle exceptions in wine tests easily, this is the only way to make it running successfully. Is there no way to check what version we're running, and only run