Re: Confusing SOCKET and int in netapi32

2008-03-24 Thread Juan Lang
> D'oh, you're right. I've sent a partial revert for this. Seems like that part > isn't tested, as make test in netapi32 worked without any problems. Right, there isn't any way to test it. We can't run NBT servers in Wine as normal users (requires a low port #, conflicts with Samba), and we can

Re: Confusing SOCKET and int in netapi32

2008-03-24 Thread Kai Blin
On Monday 24 March 2008 16:32:29 Juan Lang wrote: > Hi, commit 63504e9e80acb35666f8689526c67dd99c4fb3ba (janitorial: Use > poll() instead of select().) appears to confuse the use of a SOCKET > with an int: D'oh, you're right. I've sent a partial revert for this. Seems like that part isn't tested,

Confusing SOCKET and int in netapi32

2008-03-24 Thread Juan Lang
Hi, commit 63504e9e80acb35666f8689526c67dd99c4fb3ba (janitorial: Use poll() instead of select().) appears to confuse the use of a SOCKET with an int: #include "winsock2.h" #include "windef.h" @@ -302,13 +311,12 @@ static UCHAR NetBTWaitForNameResponse(const NetBTAdapter *adapter, SOCKET fd,