Re: Detecting patch sets

2010-04-13 Thread Sven Baars
How about this: First check it the normal way, also taking the maximum patch number into account. If a patch with a number higher than the maximum comes in that also changes tests, then you run the whole patchset again. If a set is not complete after x hours after the last patch has been se

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
> From: Dan Kegel > > when I was running patchwatcher, taking the number of patches > in the series helped more than it hurt. (It's fairly frequent for > people to submit two patchsets, and fairly infrequent for the > second patchset to have the same number of patches.) Thanks Dan, I think we hav

Re: Detecting patch sets

2010-04-13 Thread Dan Kegel
Hi Ge, when I was running patchwatcher, taking the number of patches in the series helped more than it hurt. (It's fairly frequent for people to submit two patchsets, and fairly infrequent for the second patchset to have the same number of patches.) The darn interface needed babysitting, though, s

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
> From: Wolfram Sang > > This should be a pretty rare case given that most people will use some > generators like 'git format-patch' or 'quilt' for their patch-series. > I'd say if such an error ever occurs, the series could be manually > fixed/resent. That way, you don't need to code some UI and t

Re: Detecting patch sets

2010-04-13 Thread Michael Stefaniuc
Wolfram Sang wrote: >>> you could, instead of only checking for the author, also try to check >>> for the maximum amount of patches. If you find patch [Patch 1/7], I >>> assume you currently wait for all 7 patches. Now if a patch 1/3 comes in >>> between, you'll see that the maximum is different, i

Re: Detecting patch sets

2010-04-13 Thread Wolfram Sang
>> you could, instead of only checking for the author, also try to check >> for the maximum amount of patches. If you find patch [Patch 1/7], I >> assume you currently wait for all 7 patches. Now if a patch 1/3 comes in >> between, you'll see that the maximum is different, in this case 3, so >> yo

RE: Detecting patch sets

2010-04-13 Thread Greg Geldorp
Hi Sven, > From: Sven Baars > > you could, instead of only checking for the author, also try to check > for the maximum amount of patches. If you find patch [Patch 1/7], I > assume you currently wait for all 7 patches. Now if a patch 1/3 comes in > between, you'll see that the maximum is different