Re: DirectSound, new patch available for testing

2005-11-07 Thread Molle Bestefich
Davin McCall wrote: Here's a long description of what my Alsa-driver patch does. Great explanation, thanks!!! Greatly appreciated by me and I'm sure a lot others. Previously Wine's Alsa driver was using an undocumented internal Alsa call to (_snd_pcm_hw_get_ptr, or something like that) to

Re: DirectSound, new patch available for testing

2005-11-07 Thread Davin McCall
On Mon, 7 Nov 2005 09:52:35 +0100 Molle Bestefich [EMAIL PROTECTED] wrote: Great explanation, thanks!!! Greatly appreciated by me and I'm sure a lot others. Good :-) I'm missing a point from your explanation here: Why do you even need the hardware play position? It seems that the ALSA

Re: DirectSound, new patch available for testing

2005-11-07 Thread Molle Bestefich
Thanks a lot, that answered my questions perfectly! (I hope someone implements it the right ALSA way with buffer locking someday. I'll do it, if I ever get the time /and/ learn C.. which is not likely to happen anytime soon, hehe...)

Re: DirectSound, new patch available for testing

2005-11-07 Thread Davin McCall
Juergen, Sorry for the slow reply. Thanks for responding. Because a couple of people (including yourself) had bad results with this patch, I've put it on hold for the moment, except for the alsa-driver part which has now gone into wine CVS. That alone gives a good improvement on my own system

Re: DirectSound, new patch available for testing

2005-11-06 Thread Randall Walls
Ok after a full recompile, rm-fr ~/.wine, and reinstall of the application all seems to be working fine now, with the exception that I still have the 'crackling' sound during gameplay (but that existed prior to your patch as well). Underruns are gone. As for the crackling, Alex Villacis

Re: DirectSound, new patch available for testing

2005-11-06 Thread Davin McCall
On Mon, 07 Nov 2005 18:25:49 + Randall Walls [EMAIL PROTECTED] wrote: This has since been changed with your patch to: hw_ptr = This-mmap_ppos; Just curious if you could shed a bit of light on this. As I said, the original patch did not fix my specific problem, but I would curious if

Re: DirectSound, new patch available for testing

2005-11-03 Thread Davin McCall
Here's another patch to fix the clicking noise. Once again apply over the top. With this one, I think everything should be at least as good as it was with my very first patch. (Plus the full device buffer will be used if UseDirectHW=y, which should reduce underrun problems). Davin On Thu, 3

Re: DirectSound, new patch available for testing

2005-11-03 Thread Davin McCall
Dang. Forgot to attach. --- Here's another patch to fix the clicking noise. Once again apply over the top. With this one, I think everything should be at least as good as it was with my very first patch. (Plus the full device buffer will be used if UseDirectHW=y, which should reduce underrun

DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
To all those who tested my previous patch, thanks. I have a new patch which may help to resolve some of the (few) issues which cropped up. The length not a multiple of block size issue has been partially addressed. Also, buffer underruns should be far less frequent than the previous patch if

Re: DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
On Wed, 2 Nov 2005 14:02:55 + (GMT) Robbert Xerox [EMAIL PROTECTED] wrote: Hi Davin,Two questions about this: the patch fails here at hunk 5 with current cvs. Works for me... I just made sure I had the latest files from CVS, but there have been no updates to these files since wine-0.9,

Re: DirectSound, new patch available for testing

2005-11-02 Thread Jonathan Ernst
Le jeudi 03 novembre 2005 à 10:08 +1100, Davin McCall a écrit : On Wed, 2 Nov 2005 14:02:55 + (GMT) Robbert Xerox [EMAIL PROTECTED] wrote: 2nd question: is creating the key \HKEY_CURRENT_USER\Software\Wine\Alsa Driver\UseDirectHW necessary? If so, i'll have to do that manually (in

DirectSound, new patch available for testing

2005-11-02 Thread Juergen Wieczorek
Dear Davin, in the past days I have been testing your 'old' patch with wine-0.9 on my Fedora Core 3 system (kernel-2.6.12-.1381_FC3, alsa-lib-1.0.6-8.FC3, Soundblaster Live PCI = emu10k1), using Diablo2-LoD (patch 1.11b - 3DSound = no) Now I have also tried your new patch. Outcome in short :

Re: DirectSound, new patch available for testing

2005-11-02 Thread Randall Walls
Tested again with BattleZone2 and I'm still getting what sounds like serious buffer underruns with this new patch. This one seemed to 'skip' a bit more too, depending on action taking place on screen, but that could be due to other issues (system load etc...). Running with Alsa as the audio

Re: DirectSound, new patch available for testing

2005-11-02 Thread Robert Reif
Jonathan Ernst wrote: Le jeudi 03 novembre 2005 à 10:08 +1100, Davin McCall a écrit : On Wed, 2 Nov 2005 14:02:55 + (GMT) Robbert Xerox [EMAIL PROTECTED] wrote: 2nd question: is creating the key \HKEY_CURRENT_USER\Software\Wine\Alsa Driver\UseDirectHW necessary? If so, i'll

Re: DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
Thanks for that - There was at least one problem with the patch. I've attached a fix for that (apply over the top of the previous one). I don't get buffer underruns in my own testing, but I do get an annoying clicking noise every so often (seems to be when streaming buffers wrap from the end