Re: EnterCriticalSection throws exception?

2008-07-03 Thread Huang, Zhangrong
Hi, 2008/7/3 Maarten Lankhorst [EMAIL PROTECTED]: Hello, I think that is a bad idea, while there might be 1 or 2 real genuine uses for only throwing an exception while debugging, 99% of the time it's really wine deadlocking itself, it's wine's own fault and I would rather see the backtraces

Re: EnterCriticalSection throws exception?

2008-07-03 Thread Vitaliy Margolen
Huang, Zhangrong wrote: Hi, 2008/7/3 Maarten Lankhorst [EMAIL PROTECTED]: Hello, I think that is a bad idea, while there might be 1 or 2 real genuine uses for only throwing an exception while debugging, 99% of the time it's really wine deadlocking itself, it's wine's own fault and I would

Re: EnterCriticalSection throws exception?

2008-07-03 Thread Chris Ahrendt
Huang, Zhangrong wrote: Hi, 2008/7/3 Maarten Lankhorst [EMAIL PROTECTED]: Hello, I think that is a bad idea, while there might be 1 or 2 real genuine uses for only throwing an exception while debugging, 99% of the time it's really wine deadlocking itself, it's wine's own fault and I would

EnterCriticalSection throws exception?

2008-07-02 Thread Huang, Zhangrong
a feature that EnterCriticalSection throws exception for Wine internal locks only when debug is present. Add the following code dlls/ntdll/critsection.c: NTSTATUS WINAPI RtlpWaitForCriticalSection( RTL_CRITICAL_SECTION *crit ) { ... /* Throw exception only for Wine

Re: EnterCriticalSection throws exception?

2008-07-02 Thread Rob Shearman
2008/7/2 Huang, Zhangrong [EMAIL PROTECTED]: ... On some conditions, a thread does need hold critical section more than 65 seconds, for example: wine's implementation of GetAddress uses a critical section to protect non-reentrant gethostbyname() (well maybe need another gethostbyname_r()

Re: EnterCriticalSection throws exception?

2008-07-02 Thread Huang, Zhangrong
hosts. I see. So I suggest a feature that EnterCriticalSection throws exception for Wine internal locks only when debug is present. Can we accept this feature: throw exception only when debug is present? Thanks. -- $ apt-get moo (__) (oo) /--\/ / | || * /\---/\ ~~ ~~ Have you

Re: EnterCriticalSection throws exception?

2008-07-02 Thread Maarten Lankhorst
and as a bonus it will also start supporting IPv6 hosts. I see. So I suggest a feature that EnterCriticalSection throws exception for Wine internal locks only when debug is present. Can we accept this feature: throw exception only when debug is present? I think that is a bad idea, while