Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Robert Shearman
Gerald Pfeifer wrote: } if (!HIWORD(lpszStructType)) { -switch (LOWORD(lpszStructType)) +switch ((DWORD)lpszStructType) You're just passing the problem on to people doing 64-bit builds. You should use DWORD_PTR or use LOWORD everywhere, like you suggested.

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Francois Gouget
On Mon, 15 Oct 2007, Robert Shearman wrote: Gerald Pfeifer wrote: } if (!HIWORD(lpszStructType)) { -switch (LOWORD(lpszStructType)) +switch ((DWORD)lpszStructType) You're just passing the problem on to people doing 64-bit builds. You should use

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Gerald Pfeifer
Thanks for all your feedback! On Mon, 15 Oct 2007, Dmitry Timoshkov wrote: Your fix still won't work for a 64-bit target. You would need to use ULONG_PTR cast for that. 'if (!HIWORD(lpszStructType))' line also doesn't look right in the 64-bit case. The latter is left unchanged and I'll leave

Re: Fix casts in dlls/crypt32/decode.c

2007-10-14 Thread Dmitry Timoshkov
Gerald Pfeifer [EMAIL PROTECTED] wrote: The patch below fixes the following diagnostics (rightfully) issued by GCC 4.3 and later. If you prefer, we could use LOWORD everywhere, also for the case labels, but my current patch seems to be more natural. decode.c:4365: warning: cast from