Richard Cohen wrote:
This fixes a longstanding bug whereby winemine would move 1 pixel down
the screen for every new game.
Changelog:
- Fix off-by-one in menu height calculation (& therefore
AdjustWindowRect) + test
diff -N -u -r -p dlls/user/nonclient.c dlls/user/nonclient.c
--- dlls
Richard Cohen <[EMAIL PROTECTED]> writes:
> OK. I see the problem, but it's a one of disk space, rather than
> manageability.
Well, disk space is part of manageability; but it's also an issue of
the number of files, and of the number of total tests (since each
separate test needs to create a new
Richard Cohen wrote:
Since 'gcc -c *.c -o bigobject.o' doesn't work, would something like the
attached patch (using #include) be acceptable ?
Of course you can use the same technique to compile all the user tests
in one file. The total size of the .o goes from 3.2M to 1.2M
Alexandre Julliard wrote:
There are more than 700 APIs in user32 alone. If we create a new file
for each one, that means 700 source files. Plus, with all the debug
symbols, the smallest object file weighs in at least 100K, so that's a
minimum of 70Mb of object files in that single directory. Multip
Richard Cohen <[EMAIL PROTECTED]> writes:
> We shouldn't create a new file for *every single* test, but we should
> do so for an unrelated test. How 'unmanageable' is adding 1 line to
> Makefile.in?
There are more than 700 APIs in user32 alone. If we create a new file
for each one, that means 700
Richard Cohen <[EMAIL PROTECTED]> writes:
> Yes, I saw the tests in there.
> I preferred keeping it as a separate file so that it is simple to
> understand - it just runs through all the window styles and checks
> AdjustWindowRect. win.c is already over 2000 lines long!
We can't create a new fil
Dmitry Timoshkov wrote:
dlls/user/tests/win.c already has AdjustWindowRect tests,
see test_nonclient_area. If you could add your tests there
that would be great.
Yes, I saw the tests in there.
I preferred keeping it as a separate file so that it is simple to
understand - it just runs through all t
"Richard Cohen" <[EMAIL PROTECTED]> wrote:
> Changelog:
> + Improve AdjustWindowRect
> + add a test
dlls/user/tests/win.c already has AdjustWindowRect tests,
see test_nonclient_area. If you could add your tests there
that would be great.
--
Dmitry.
