Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
On Mon, Jun 18, 2012 at 11:41 AM, Dmitry Timoshkov wrote: >> +     /* In some apps, the hotkey doesn't draw unless we invalidate it here >> */ >> +     InvalidateRect(infoPtr->hwndSelf, NULL, FALSE); > > It doesn't make sense to invalidate before painting in

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dmitry Timoshkov
Dan Kegel wrote: > @@ -190,6 +190,8 @@ HOTKEY_Paint(HOTKEY_INFO *infoPtr, HDC hdc) > HOTKEY_Refresh(infoPtr, hdc); > else { > PAINTSTRUCT ps; > + /* In some apps, the hotkey doesn't draw unless we invalidate it here */ > + InvalidateRect(infoPtr

Re: comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Austin English
On Mon, Jun 18, 2012 at 11:14 AM, Dan Kegel wrote: > In at least one app, the hotkey control doesn't draw itself. > Invalidating its own window during HOTKEY_Paint gets the > control to draw properly, and makes the app happy. > > Fixes http://bugs.winehq.org/show_bug.cgi?id

comctl32: hotkey control needs to invalidate itself when painting for some apps

2012-06-18 Thread Dan Kegel
In at least one app, the hotkey control doesn't draw itself. Invalidating its own window during HOTKEY_Paint gets the control to draw properly, and makes the app happy. Fixes http://bugs.winehq.org/show_bug.cgi?id=30486 (Unlike the patch attached to that bug, this one doesn't al

Re: [2/7] server: Post WM_HOTKEY when a hotkey is pressed.

2011-06-15 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11759 Your paranoid android

Re: [1/6] user32: Ignore painting messages in the hotkey test using a wndproc.

2011-06-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11706 Your paranoid android

Re: [2/6] user32: Add a test to find the queue containing hotkey messages.

2011-06-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11707 Your paranoid android

Re: [5/7] user32: Do not check the last error on succeeding hotkey calls.

2011-06-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11550 Your paranoid android

Re: [4/7] user32: Test registering the same hotkey hwnd/id pair twice.

2011-06-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11549 Your paranoid android

Re: [2/7] user32: Ignore paint messages in hotkey tests.

2011-06-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=11547 Your paranoid android

Requesting testing for the hotkey implementation

2006-10-10 Thread Aaron Slunt
any issues with it. The primary concern for this patch would be to see what happens when two separate programs, or two instances of the same program, try to register a hotkey that is already in use. Please let me know how this turns out. It would be really great to finally have this in wine, b

Hotkey

2006-02-23 Thread Christian Gmeiner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all. I want to fix the hotkey stuff in user.dll. Now i have asked at xorg mail list and thy told me that i should use acpid to do hotkey stuff. Now i think we should to hotkey stuff internal in wine: Have a hash list to save hotkeys and check