Re: Implemented CreateAsyncBindCtx

2004-12-07 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > It's my tiny bug. RegsterObjectParam can fail only with E_OUTOFMEMORY > here, so checking it's return is > really not important, but to be correct at all, hres should be just > returned. No, that's worse than before, now you return an error while still al

Re: Implemented CreateAsyncBindCtx

2004-12-05 Thread Jacek Caban
Mike Hearn wrote: On Fri, 03 Dec 2004 23:01:36 -0500, Jacek Caban wrote: +hres = IBindCtx_RegisterObjectParam(bctx, (LPOLESTR)BSCBHolder, (IUnknown*)callback); + +*pbind = bctx; + +return S_OK; } You don't do anything with hres here, is that intentional? Can RegisterObjectParam

Re: Implemented CreateAsyncBindCtx

2004-12-04 Thread Mike Hearn
On Fri, 03 Dec 2004 23:01:36 -0500, Jacek Caban wrote: > +hres = IBindCtx_RegisterObjectParam(bctx, (LPOLESTR)BSCBHolder, > (IUnknown*)callback); > + > +*pbind = bctx; > + > +return S_OK; > } You don't do anything with hres here, is that intentional? Can RegisterObjectParam fail? th