Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-28 Thread Jeff Cook
On Tue, Aug 17, 2010 at 3:00 AM, sudemon wrote: > On 03.08.2010 04:36, Jeff Cook wrote: >> >> What compiler are you running? It works fine for me and I don't see >> any errors or warnings. > > I also don't see any errors or warnings. > > Аfter 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 commit - my g

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-17 Thread sudemon
On 03.08.2010 04:36, Jeff Cook wrote: What compiler are you running? It works fine for me and I don't see any errors or warnings. I also don't see any errors or warnings. Аfter 6120d7cc14522983fbc38026ab4fcb6e4a68cdf0 commit - my games just crash on start without errors (windows version is win

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 3)

2010-08-03 Thread Vitaliy Margolen
On 08/02/2010 05:48 PM, Jeff Cook wrote: Moved check to conform with C90. +if (mastelem) { +/* Master control */ ... +} else { Please follow file's format. Vitaliy

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-03 Thread Michael Stefaniuc
Jeff Cook wrote: > What compiler are you running? It works fine for me and I don't see > any errors or warnings. You are passing the compiler the wrong flags: -Wdeclaration-after-statement is set by default in Wine. > On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard > wrote: >> Jeff Cook writ

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Ricardo Filipe
2010/8/2 Jeff Cook : > What compiler are you running? It works fine for me and I don't see > any errors or warnings. > > On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard > wrote: >> Jeff Cook writes: >> >>> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>>      for (id = 0; id <

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Jeff Cook
What compiler are you running? It works fine for me and I don't see any errors or warnings. On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard wrote: > Jeff Cook writes: > >> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>      for (id = 0; id < mmixer->chans; ++id) >>      { >>

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Alexandre Julliard
Jeff Cook writes: > @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) > for (id = 0; id < mmixer->chans; ++id) > { > line *mline = &mmixer->lines[id]; > +if (!mline->elem) > +{ > +break; > +} > int ofs = CONTROLSPERLINE *

Init mixer on cards with a single Mic control, like snd_usb_audio mics

2010-07-17 Thread Jeff Cook
This patch fixes bug #12706 and creates a mixer for snd-usb-audio cards, which have only a single Mic control and nothing else. Subsequent patches may be needed to make this useful depending on configuration. I am including this here for commentary before I submit to wine-patches. This is my f