Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-31 Thread Robert Shearman
Marcus Meissner wrote: On Sat, Dec 31, 2005 at 11:12:33AM +0900, Mike McCormack wrote: Robert Shearman wrote: These changes are wrong. IStream_Read can return S_FALSE, which means that the call was successful, but didn't do what was intended. From MSDN: S_FALSE The data cannot be r

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-31 Thread Marcus Meissner
On Sat, Dec 31, 2005 at 11:12:33AM +0900, Mike McCormack wrote: > > Robert Shearman wrote: > > >These changes are wrong. IStream_Read can return S_FALSE, which means > >that the call was successful, but didn't do what was intended. From MSDN: > > > >S_FALSE > > The data cannot be read from the

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-30 Thread Mike McCormack
Robert Shearman wrote: These changes are wrong. IStream_Read can return S_FALSE, which means that the call was successful, but didn't do what was intended. From MSDN: S_FALSE The data cannot be read from the stream object. Depending on the implementation, either S_FALSE or an error code

Re: OLEAUT32: Use the FAILED macro to check for failure of interface methods.

2005-12-30 Thread Robert Shearman
Mike McCormack wrote: } hr=IStream_Read(pStm,header,8,&xread); - if (hr || xread!=8) { + if (FAILED(hr) || xread!=8) { FIXME("Failure while reading picture header (hr is %lx, nread is %ld).\n",hr,xread); return hr; } @@ -1128,10 +1128,10 @@ static HRESULT WINAPI OLEPictureIm