2010/1/8 Wolfram Sang :
> Geoffrey Hausheer wrote:
>
>> Would someone mind reviewing this for style/content? I still have no
>
> Can't say much about the content, but stylewise the pointer handling
> could be improved. For example,
>
> + if ( (iface==0) || (ppvObject==0) )
>
> should at least u
Geoffrey Hausheer wrote:
> Would someone mind reviewing this for style/content? I still have no
Can't say much about the content, but stylewise the pointer handling
could be improved. For example,
+if ( (iface==0) || (ppvObject==0) )
should at least use NULL instead of 0 as both are pointe
Ok, I have reimplemented OleCreatePropertyFrame() from scratch. There
is no code from Hidenori's patch in mine, nor did I use it as a
reference (though of course I can't claim that I didn't learn anything
from his patch during my previous cleanup)
Would someone mind reviewing this for style/conte
On Mon, Jan 4, 2010 at 7:18 PM, Geoffrey Hausheer
wrote:
> On Mon, Jan 4, 2010 at 9:06 AM, Wolfram Sang wrote:
>>> task. There doesn't appear to be anything in this code that would be
>>> patent encumbered, but the code itself certainly falls under
>>> Hidenori's copyright which he has effective
On Mon, Jan 4, 2010 at 9:06 AM, Wolfram Sang wrote:
>> task. There doesn't appear to be anything in this code that would be
>> patent encumbered, but the code itself certainly falls under
>> Hidenori's copyright which he has effectively revoked permission to
>> use.
>
> Strictly speaking, this is
task. There doesn't appear to be anything in this code that would be
patent encumbered, but the code itself certainly falls under
Hidenori's copyright which he has effectively revoked permission to
use.
Strictly speaking, this is not possible. Although IANAL, this code is
LGPL, so he can't r
On Mon, Jan 4, 2010 at 4:39 AM, John Klehm wrote:
> On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies wrote:
>> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
>>> I found a patch from 2001 written by TAKESHIMA Hidenori that
>>> was posted to wine-patches
>>> (http://www.winehq.org/pip
On Mon, Jan 4, 2010 at 4:46 AM, Huw Davies wrote:
> On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
>> I found a patch from 2001 written by TAKESHIMA Hidenori that
>> was posted to wine-patches
>> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html)
>> but nev
On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote:
> I found a patch from 2001 written by TAKESHIMA Hidenori that
> was posted to wine-patches
> (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html)
> but never committed.
Actually it was commited (2843934af5515c7f
Hi Geoffrey,
2010/1/4 Geoffrey Hausheer :
> Some software I'm using is configured via an OleCreatePropertyFrame
> call which isn't implemented in Wine (ticket #16564). I can use
> winetricks + dcom98 to get it working, but would prefer not to need
> that. I found a patch from 2001 written by TAK
Some software I'm using is configured via an OleCreatePropertyFrame
call which isn't implemented in Wine (ticket #16564). I can use
winetricks + dcom98 to get it working, but would prefer not to need
that. I found a patch from 2001 written by TAKESHIMA Hidenori that
was posted to wine-patches
(ht
11 matches
Mail list logo
