Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-18 Thread Henri Verbeet
2008/11/18 Stefan Dösinger <[EMAIL PROTECTED]>: > I think it would be better f getColorBits returned a proper error to the > caller, and the caller handles these errors without spamming the FIXME or > ERR channel. That would seem better to me than prefiltering the parameters > It does, it returns F

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-18 Thread Henri Verbeet
> +switch(Format) > +{ > +case WINED3DFMT_X8R8G8B8: > +case WINED3DFMT_R8G8B8: > +case WINED3DFMT_A8R8G8B8: > +case WINED3DFMT_A2R10G10B10: > +case WINED3DFMT_X1R5G5B5: > +case WINED3DFMT_A1R5G5B5: > +

re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-17 Thread Dan Kegel
Andrew wrote: >When sending a patch to wine-patches put the patch number followed by >how many patches you are sending so the automated scripts can read it. yes, please! > For example "[1/1] sending only one patch". Poor example, please don't do it on single patches. You only need to do it for s

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games

2008-11-17 Thread Andrew Fenn
Your patch adds extra whitespace on an empty line. You are mixing coding styles with your if statements. When sending a patch to wine-patches put the patch number followed by how many patches you are sending so the automated scripts can read it. For example "[1/1] sending only one patch". 2008/1