Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-19 Thread Hans Leidekker
On Monday 19 October 2009 04:19:07 Nathan Gallaher wrote: > Resubmit of patch. > > Patch separated into test and fix components. > Patch rebased. > tableName variable --> table_name > Commented code removed. > Unused variables removed > Unnecessary debug printf's removed. Looks good, please subm

Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-18 Thread Nathan Gallaher
Resubmit of patch. Patch separated into test and fix components. Patch rebased. tableName variable --> table_name Commented code removed. Unused variables removed Unnecessary debug printf's removed. Thanks for the review, ~Nate On Thu, 1 Oct 2009, Hans Leidekker wrote: Hi Nate, Your patch a

Re: Patch for bug 20227: msi: Table Join on two tables that have same (non-join) column name...

2009-10-01 Thread Hans Leidekker
Hi Nate, Your patch applies with offsets, please rebase to current git. And get rid of this warning: db.c: In function ‘test_where_not_in_selected’: db.c:1576: warning: unused variable ‘count’ > +query = /*"Select IESTable.Action, IESTable.Condition from CATable, > IESTable where "*/ > +