Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-10 Thread Ben Klein
2009/3/10 Forest Hale lordha...@ghdigital.com: Ben Klein wrote: You're wrong there, it's DRIVE_UNKNOWN, which is the autodetect thing (I haven't looked into it in detail, but something is *correctly* autodetecting your drive C: as a network drive). snip I'm still pretty sure kernel32 isn't

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-10 Thread Forest Hale
Ben Klein wrote: You're wrong there, it's DRIVE_UNKNOWN, which is the autodetect thing (I haven't looked into it in detail, but something is *correctly* autodetecting your drive C: as a network drive). snip I'm still pretty sure kernel32 isn't the right place for forcing drive type. Maybe

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-08 Thread Forest Hale
I happen to agree with that sentiment, but Wine creates ~/.wine/drive_c and configures it as C:, for the sake of all common users this is correct. To force C: to be a fixed drive is not harmful in any case I can think of. It does not help if you set up wine with an installation in another drive

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-08 Thread Ben Klein
2009/3/8 Forest Hale lordha...@ghdigital.com: I happen to agree with that sentiment, but Wine creates ~/.wine/drive_c and configures it as C:, for the sake of all common users this is correct. To force C: to be a fixed drive is not harmful in any case I can think of. It does not help if you

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-08 Thread Ben Klein
2009/3/8 Forest Hale lordha...@ghdigital.com: The problem with mountmgr is that it's not even calling the type function because the NtQueryVolumeInformationFile is asking the Linux kernel about this path and the Linux kernel is saying it's in an NFS filesystem on my computer (which is true),

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-08 Thread Forest Hale
The problem with mountmgr is that it's not even calling the type function because the NtQueryVolumeInformationFile is asking the Linux kernel about this path and the Linux kernel is saying it's in an NFS filesystem on my computer (which is true), then it's reporting it as a network drive, and

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-08 Thread Austin English
On Sat, Mar 7, 2009 at 1:13 PM, Forest Hale lordha...@ghdigital.com wrote: I happen to agree with that sentiment, but Wine creates ~/.wine/drive_c and configures it as C:, for the sake of all common users this is correct. To force C: to be a fixed drive is not harmful in any case I can think

Re: Patch to fix bug 17619 - GetDriveTypeW reporting C: as a network share if /home is an NFS share

2009-03-07 Thread Francois Gouget
On Fri, 6 Mar 2009, Forest Hale wrote: Fixed GetDriveTypeW to always report C: as DRIVE_FIXED, preventing problems with the Steam installer if /home is a network share or other special mount. +if (root (root[0] == 'C' || root[0] == 'c')) return DRIVE_FIXED; I think you should not