Re: Preprocessing asm shaders

2012-03-13 Thread Józef Kucia
On Tue, Mar 13, 2012 at 1:22 PM, Matteo Bruni wrote: > That is bug http://bugs.winehq.org/show_bug.cgi?id=24614. My shot at > it was http://www.winehq.org/pipermail/wine-patches/2011-February/098609.html. > You can see that my approach was essentially what you are suggesting. > Still, that's not a

Re: Preprocessing asm shaders

2012-03-13 Thread Matteo Bruni
Il 12 marzo 2012 22:13, Józef Kucia ha scritto: > Hi, > > I'm writing because I found a bug in asm shader preprocessor in Wine > and I'm not sure what's the best way to fix it. > > The D3DPreprocess function is an universal shader preprocess for HLSL > and asm shaders. In fact, it's C-like languag

Re: Preprocessing asm shaders

2012-03-13 Thread Stefan Dösinger
Am Dienstag, 13. März 2012, 00:52:58 schrieb Józef Kucia: > I'll make some tests to check how wrc and widl should behave. However > I'm not sure if submitting tests for wrc and widl would be welcome. We > don't have any tests for these tools yet and I can imagine not > everyone, who's running the t

Re: Preprocessing asm shaders

2012-03-12 Thread Józef Kucia
On Mon, Mar 12, 2012 at 11:31 PM, Stefan Dösinger wrote: > My first guess would be to see how other users of wpp are behaving, or are > supposed to behave. grep claims that the other parts of Wine that use wpp are > toold/widl and tools/wrc. Beyond those it's probably a good idea to keep HLSL > in

Re: Preprocessing asm shaders

2012-03-12 Thread Stefan Dösinger
Am Montag, 12. März 2012, 22:13:45 schrieb Józef Kucia: > I wonder if it's fine to change wpp behavior for strings passing the > end of line to mimic the behavior observed on Windows. Perhaps, > strings passing the end of line could be treated as an error by > default. Whereas D3DCompiler would act

Preprocessing asm shaders

2012-03-12 Thread Józef Kucia
Hi, I'm writing because I found a bug in asm shader preprocessor in Wine and I'm not sure what's the best way to fix it. The D3DPreprocess function is an universal shader preprocess for HLSL and asm shaders. In fact, it's C-like language preprocessor and it doesn't understand assembler style comm