[mailto:adge...@hotmail.com]
Sent: Thursday, December 25, 2008 1:06 AM
To: ste...@codeweavers.com; wine-devel@winehq.org
Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer
(re-redux)
Thanks for the explanation -- I will email asking why soon -- and
perhaps resubmit
Thanks for reviewing my patch (it sure makes the SHOGO menu much nicer)
BTW do you know if I need to resubmit my other SHOGO patch ([PATCH] Fix
ddraw surface version setting)?
Yes, I recommend to do that. It is likely that it was lost or didn't apply
any longer after the 3 days it waited in
From: ste...@codeweavers.com
To: adge...@hotmail.com; wine-devel@winehq.org
Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer
(re-redux)
Date: Wed, 24 Dec 2008 15:48:24 +0100
Thanks for reviewing my patch (it sure makes the SHOGO menu much nicer)
BTW do you know if I
This patch looks good.
There's one last thing we should check: It seems that this is the only code
that uses GL_PACK_ROW_LENGTH and friends, so the backup and restore is
probably not needed. I think for now it is better to add it because I
suspect the code in surface_download_data most likely
list)
- Nick
From: ste...@codeweavers.com
To: wine-devel@winehq.org
Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer
(re-redux)
Date: Tue, 23 Dec 2008 13:30:40 +0100
This patch looks good.
There's one last thing we should check
3.7.4). However, the
language describing pixel rectangles in section 3.7 is retained as it is
required
for TexImage* and ReadPixels. - Nick From: adge...@hotmail.com To:
ste...@codeweavers.com; wine-devel@winehq.org Subject: RE: [PATCH] Fix
glReadPixels call from read_from_framebuffer (re
Hmm... Wouldn't this bug also affect surfaces without a PBO?
-Original Message-
From: wine-patches-boun...@winehq.org [mailto:wine-patches-
boun...@winehq.org] On Behalf Of Nick Burns
Sent: Sunday, December 21, 2008 12:36 PM
To: wine-patc...@winehq.org
Subject: [PATCH] Fix
-resubmit my patch
- Nick
From: ste...@codeweavers.com
To: wine-devel@winehq.org; wine-patc...@winehq.org
Subject: RE: [PATCH] Fix glReadPixels call from read_from_framebuffer (redux)
Date: Mon, 22 Dec 2008 13:05:36 +0100
Hmm... Wouldn't this bug also
On Sun, Dec 21, 2008 at 4:40 PM, Nick Burns adge...@hotmail.com wrote:
This is my last gfx fix for SHOGOThe readpixels call was putting data into
the wrong place in the pbo(fixed with pixelstore)And the y-flip code was
flipping the wrong data as well(set the bottom row to the bottom
-- I choose plain
text...)
- Nick
Date: Sun, 21 Dec 2008 17:03:55 +1100
From: jeffzaro...@gmail.com
To: adge...@hotmail.com
Subject: Re: [PATCH] Fix glReadPixels call from read_from_framebuffer
CC: wine-devel@winehq.org
On Sun, Dec 21, 2008 at 4:40
10 matches
Mail list logo
