Re: Patch for WineD3D to set Driver an Description (try 2)

2009-03-15 Thread Henri Verbeet
2009/3/14 Mirek Slugeň : > Hi, Fallout 3 and maybe other games or D3D apps needs such special > settings, this patch should be ok, it is well tested. > > This patch is not hack! > You're leaking wined3d_settings.video_description and wined3d_settings.video_driver. Having an override would be ok, b

Re: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Mirek Slugeň
Hi, but this patch shouldn't brake anything, because it will use wine default driver name and description and if user want to change it then he can in registry, same like amount of video memory. In the future we will not be able to exactly match driver name and description in every situation, s

Re: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Chris Robinson
On Wednesday 12 November 2008 05:26:45 am Stefan Dösinger wrote: > "nv4_disp.dll" obviously makes problems. Our display driver is called > "winex11.drv", or arguably for d3d "wined3d.dll" Unfortunately I tried this (setting the display driver to "wined3d.dll"), and Fallout 3 still crashes. Seems

Re: RE: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Henri Verbeet
2008/11/12 Roderick Colenbrander <[EMAIL PROTECTED]>: > So the default should be the table but users should always be able to > override it as we can never get it correctly in all situations. > > Roderick > Sounds reasonable.

Re: RE: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Roderick Colenbrander
The registry key isn't bad. There should also come a key to override the pci id. By default we will use the table and I plan to fix that one properly soon. I talked about it to Henri and I thought that the name 'Display' is used in several places and that likely we need to get the driver name fr

RE: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Stefan Dösinger
> PS: For Fallout 3 those registry settings should be (or similar): > "VideoDescription"="NVIDIA GeForce 9600 GT" > "VideoDriver"="nv4_disp.dll" We have a display driver database in wined3d that specifies the driver version to report. We could include this information there instead adding a new

Re: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Roderick Colenbrander
Perhaps the patch should enter Wine. I will do the full restructuring later. One thing which you should do is to set the strings to NULL in the wined3d_settings structure at the start of the file (line 37). Also put the new options right after the video memory one or even before for clarity. Ro

Re: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Roderick Colenbrander
> 2008/11/7 Mirek Slugeň <[EMAIL PROTECTED]>: > > Hi, Fallout 3 and maybe other games or D3D apps need such special > settings, > > this patch should be ok, it is well tested. > > > > This patch is not hack! > > > > New wine registry settings: > > VideoDriver > > VideoDescription > > > > Patch is f

Re: Patch for WineD3D to set Driver an Description

2008-11-12 Thread Henri Verbeet
2008/11/7 Mirek Slugeň <[EMAIL PROTECTED]>: > Hi, Fallout 3 and maybe other games or D3D apps need such special settings, > this patch should be ok, it is well tested. > > This patch is not hack! > > New wine registry settings: > VideoDriver > VideoDescription > > Patch is for current (07.11.2008)