"Igor Grahek" <[EMAIL PROTECTED]> writes:
> Is there a reason why this is not accepted?
>
> ChangeLog: - TreeView control set Notify window correctly in case that
> window style is WS_POPUP.
I still don't think the IsWindow thing is correct. Have you checked
what Windows does in that case?
--
A
fy == HWND_MESSAGE)
+infoPtr->hwndNotify = GetParent(hwnd);
but not removed.
Igor
> -Original Message-
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED]
> Sent: September 10, 2003 6:31 PM
> To: Igor Grahek
> Cc: [EMAIL PROTECTED]
> Subject: Re: TreeView control
"Igor Grahek" <[EMAIL PROTECTED]> writes:
> +infoPtr->hwndNotify = lpcs->hwndParent;
> +if(!IsWindow(infoPtr->hwndNotify))
> +infoPtr->hwndNotify = GetParent(hwnd);
Why do you need the IsWindow() check? AFAICS the parent should always
be valid (or possibly 0 but then GetParent()
On Tue, 9 Sep 2003, Igor Grahek wrote:
> Do you think something like this will do?
Yes, this looks much better.
> I also checked some other controls in comctl32 and every implementation
> is different. Usualy there is no hwndNotify and GetParent() is used in
> SendMessageW calls and all of these
replaced. Luckily most of
control implementations are already forwarding lpcs to *_Create
functions.
Igor
> -Original Message-
> From: Dimitrie O. Paun [mailto:[EMAIL PROTECTED]
> Sent: September 9, 2003 10:35 AM
> To: Igor Grahek
> Cc: [EMAIL PROTECTED]
> Subject: RE:
On Tue, 9 Sep 2003, Igor Grahek wrote:
> I'm pretty new at Wine patching and CreateWindowEx does some other
> parent checking so I didn't want to break anything else by fixing this
> one.
Yes, but this solution just looks to ugly to be propagated to the
other controls. Let's find a nice one that
EMAIL PROTECTED]; Igor Grahek
> Subject: Re: TreeView control - set correct hwndNotify
>
>
> On September 8, 2003 03:52 pm, Igor Grahek wrote:
> > ChangeLog: - TreeView control set Notify window correctly
> in case that
> > window style is WS_POPUP.
>
> Please
On September 8, 2003 03:52 pm, Igor Grahek wrote:
> ChangeLog: - TreeView control set Notify window correctly in case that
> window style is WS_POPUP.
Please send unidiff patches:
http://www.winehq.org/site/sending_patches
> ! if ((infoPtr->dwStyle & (WS_CHILD|WS_POPUP)) == WS_POPUP &&
>