RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Stefan Dösinger
I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if it crashes on something like VMWare or other 'noname'

Re: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Henri Verbeet
2008/12/23 Stefan Dösinger ste...@codeweavers.com: I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Stefan Dösinger
The patch is already applied, but I think removing the test is the right thing to do. I only added the test to test what error d3d9 returns when a NULL shader is passed. If it depends on the driver, I doubt we care. This patch was a good idea, yes I'm only afraid of this hypothetical

RE: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Detlef Riekenberg
On Di, 2008-12-23 at 14:24 +0100, Stefan Dösinger wrote: I'm only afraid of this hypothetical scenario: 1) We remove a test because it breaks on $NONSTANDARDWINDRV We disable the test with: if (0) { /* that crash on $NONSTANDARDWINDRV */ full test here } 3) Some

Re: d3d9/tests: Don't create a Null-shader in d3d9, it will crash.

2008-12-23 Thread Rico Schüller
Stefan Dösinger schrieb: I never saw this crashing on any of my systems, so it is probably driver dependent. Which Windows driver are you using? If the test crashes on either ATI, Nvidia or Intel it is a good idea to remove it. I don't think we should remove it if it crashes on something