On Fri Dec 12 0:58 , Michael Stefaniuc sent:
Andrew Talbot wrote:
What is wrong with this patch, please?
If I may venture a guess: You have replaced a nice and concise for loop
into and ugly 4 line while loop.
bye
michael
Hi Michael,
Ugly? Andrew Koenig and Barbara Moo show a
Ugly? Andrew Koenig and Barbara Moo show a similar construct in their book
Accelerated C++. ;)
A little off topic, but this is on page 19, before for loops are
introduced. If you look ahead to page 27 (2.5.2) that example is
redone with a for loop.
Chris.
Andrew Talbot wrote:
On Fri Dec 12 0:58 , Michael Stefaniuc sent:
Andrew Talbot wrote:
What is wrong with this patch, please?
If I may venture a guess: You have replaced a nice and concise for loop
into and ugly 4 line while loop.
Ugly? Andrew Koenig and Barbara Moo show a similar
On Fri Dec 12 10:29 , Michael Stefaniuc mstef...@redhat.com sent:
Andrew Talbot wrote:
But how would you then fix the sign-compare violation, or would you just let
this
one go?
I had to look twice as the initial warning was in a for loop above:
Either leave it as is for now as the warning
But how would you then fix the sign-compare violation, or
would you just let this one go?
If you want it to be more compact:
unsigned int i;
...
for (i = sizeof(foo) / sizeof(foo[0]) - 1; ~i; --i)
Tested? No.
Readable? Don't ask me... :-)
Cheers,
Peter
Peter Rosin p...@axentia.se at: Dec 12, 2008 4:27 AM wrote about: RE: winmm:
Sign-compare warning fix (Resend)
But how would you then fix the sign-compare violation, or
would you just let this one go?
If you want it to be more compact:
unsigned int i;
...
for (i = sizeof(foo
Am Freitag, den 12.12.2008, 09:07 -0700 schrieb James Mckenzie:
unsigned int i;
...
for (i = sizeof(foo) / sizeof(foo[0]) - 1; ~i; --i)
Tested? No.
Readable? Don't ask me... :-)
I understood it, but is not the goal to avoid the use of C++ constructs in
WINE code?
There is no
Michael Karcher w...@mkarcher.dialup.fu-berlin.de at: Dec 12, 2008 9:23 AM
(MST) wrote about: RE: winmm: Sign-compare warning fix (Resend)
Am Freitag, den 12.12.2008, 09:07 -0700 schrieb James Mckenzie:
unsigned int i;
...
for (i = sizeof(foo) / sizeof(foo[0]) - 1; ~i; --i
Andrew Talbot wrote:
What is wrong with this patch, please?
If I may venture a guess: You have replaced a nice and concise for loop
into and ugly 4 line while loop.
bye
michael
---
Changelog:
winmm: Sign-compare warning fix.
diff --git a/dlls/winmm/lolvldrv.c
