Re: RFC: XEmbed Systray Patches

2006-08-15 Thread James Liggett
On Tue, 2006-08-15 at 12:14 +0100, Mike Hearn wrote: > Great work! Now let's hope Alexandre accepts it. We're working on it. I talked about it briefly with Alexandre this morning on IRC. ATM he thinks I should get rid of the low-level checks for the systray windows. He suggested that I do somethin

Re: RFC: XEmbed Systray Patches

2006-08-15 Thread Mike Hearn
On 8/15/06, James Liggett <[EMAIL PROTECTED]> wrote: Just FYI--I figured out what was wrong with my X test app. I just needed to set some size hints on the window, and now the size is perfect when the window docks. Now I've got my test app, a GNOME program, and some wine apps all peacefully coexi

Re: RFC: XEmbed Systray Patches

2006-08-15 Thread Alexandre Julliard
James Liggett <[EMAIL PROTECTED]> writes: > +{ > +if ((X11DRV_get_systray_window( display ) == None) || > +(!(ex_style & WS_EX_TRAYWINDOW))) > +{ > +XMapWindow( display, data->whole_window ); > +

RFC: XEmbed Systray Patches

2006-08-14 Thread James Liggett
Hi Everyone, First, I'd like to apologize for sending those tarballs to wine-devel, as I've just been advised on IRC that such a practice discourages reviews. I've attached a text version of the patches in the hopes that it will get some more exposure. Again, sorry for the trouble. :) James >Fro

Re: RFC: XEmbed Systray Patches

2006-08-14 Thread James Liggett
On Wed, 2006-08-09 at 13:30 -0700, James Liggett wrote: > > also a problem where a window would dock but only be allocated 1 > > pixel, I think that was a bug in GNOME that is now fixed. > I'm not quite sure about that one--I've got an X test app that docks, > but I can only get 1 pixel wide. :( O

Re: RFC: XEmbed Systray Patches

2006-08-10 Thread James Liggett
On Thu, 2006-08-10 at 00:16 +0100, Mike Hearn wrote: > You can always stick some needed field in the X11DRV private data (you > can see how to access that in the code itself). OK--I apologize for being so dumb. it's the server reply that needs the extended styles field, not X11DRV_win_data. Sorry t

Re: RFC: XEmbed Systray Patches

2006-08-09 Thread James Liggett
On Thu, 2006-08-10 at 00:16 +0100, Mike Hearn wrote: > > You can always stick some needed field in the X11DRV private data (you > can see how to access that in the code itself). Are you referring to x11drv_win_data? I looked at that, but it seems cleaner if I just use GetWindowLongW. I don't know

Re: RFC: XEmbed Systray Patches

2006-08-09 Thread Mike Hearn
On 8/9/06, James Liggett <[EMAIL PROTECTED]> wrote: way to handle it. What we need to do is get the extended style of the window, but this seems to involve a bunch of wineserver calls that I'm not familiar with. Can you help me out on that? Thanks! You can always stick some needed field in the

Re: RFC: XEmbed Systray Patches

2006-08-09 Thread James Liggett
On Wed, 2006-08-09 at 12:16 +0100, Mike Hearn wrote: > Ah awesome, good work! I know when I looked at this originally it > seemed you could set a flag that told the embedder whether it was > already mapped or not, maybe that doesn't work properly. It's not that it doesn't work properly. What happe

Re: RFC: XEmbed Systray Patches

2006-08-09 Thread Mike Hearn
On 8/9/06, James Liggett <[EMAIL PROTECTED]> wrote: Actually, I don't think it has to do with synchronization--I think it has to do with window mapping. Ah awesome, good work! I know when I looked at this originally it seemed you could set a flag that told the embedder whether it was already ma

Re: RFC: XEmbed Systray Patches

2006-08-08 Thread James Liggett
On Tue, 2006-08-08 at 13:48 +0100, Mike Hearn wrote: > > It's not that we need to slow it down - slowing something down is > never an acceptable solution to a race. We are missing some kind of > synchronisation somewhere, > Actually, I don't think it has to do with synchronization--I think it

Re: RFC: XEmbed Systray Patches

2006-08-08 Thread Mike Hearn
On 8/7/06, James Liggett <[EMAIL PROTECTED]> wrote: Turns out you're right, Mike. If I add a small (2 ms) sleep after the dock event is sent, things work perfectly. :) But, this really strikes me as a hack that doesn't stand a chance of getting into Wine. Is there a better way to slow down the ex

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread James Liggett
On Mon, 2006-08-07 at 18:02 +0100, Mike Hearn wrote: > On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > > so I suspect that this has something to do with stack problem > > More likely it's a speed issue - logging slows the code down a lot which > could "fix" a race condition. X is sort o

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread James Liggett
On Mon, 2006-08-07 at 18:02 +0100, Mike Hearn wrote: > On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > > so I suspect that this has something to do with stack problem > > More likely it's a speed issue - logging slows the code down a lot which > could "fix" a race condition. X is sort o

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread Mike Hearn
On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > so I suspect that this has something to do with stack problem More likely it's a speed issue - logging slows the code down a lot which could "fix" a race condition. X is sort of susceptible to this kind of thing it seems.

RFC: XEmbed Systray Patches

2006-08-06 Thread James Liggett
Hello everyone, After a long hiatus, I'm trying again to get XEmbed systray support into Wine. I've been working on it for the past few days and I've got these patches. These are based on the system tray code from the Wine version used in the Linux port of Picasa [1] (which in turn was based on the