Re: RFC: msvcrt: support dates after year 2038 in mktime64

2010-05-31 Thread Robert Wilhelm
On Sun, 2010-05-30 at 13:02 -0700, James McKenzie wrote: > I think I know your confusion here. Does UNIX and Windows implement > these functions for the same date range or should we be rejecting a set > of dates as being invalid? > Windows has 1970-2038 for mktime32 and 1970-3000 for _mktime6

Re: RFC: msvcrt: support dates after year 2038 in mktime64

2010-05-30 Thread James McKenzie
Robert Wilhelm wrote: Hello James, seems I should better send patches as attachments. http://testbot.winehq.org/JobDetails.pl?Key=2393 was more successfully. I am not sure I got your question. On 64bit unix systems (which have 64bit time_t), mktime() will support dates after year 2038. There is

Re: RFC: msvcrt: support dates after year 2038 in mktime64

2010-05-30 Thread Robert Wilhelm
Hello James, seems I should better send patches as attachments. http://testbot.winehq.org/JobDetails.pl?Key=2393 was more successfully. I am not sure I got your question. On 64bit unix systems (which have 64bit time_t), mktime() will support dates after year 2038. There is no need for my patch.

Re: RFC: msvcrt: support dates after year 2038 in mktime64

2010-05-30 Thread James McKenzie
(Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2394 Your

Re: RFC: msvcrt: support dates after year 2038 in mktime64

2010-05-30 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2394 Your paranoid android.