Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-25 Thread Dmitry Timoshkov
Eric Pouech wrote: > my point was not just to say that most of the information put in current > TRACE/WARN/FIXME/ERR statements contain more decimal than hexadecimal > formats > so obviously, not everybody expects hexa all over the place Of course each TRACE statements serve the pupose of each

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-24 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech wrote: hmm sounds like most of the code we have in not in sync [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-20 Thread Dmitry Timoshkov
Eric Pouech wrote: > hmm sounds like most of the code we have in not in sync > > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*d" | wc -l > 8767 > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*x" | wc -l > 4136 I specifiacally me

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Juan Lang
> my point is just saying that 2/3 of the information put in traces is in > decimal > which is a measurement of what is expected as format for integral values Yes, I understand. And I'm saying that such an estimate likely overstates the utility of decimal format for integral values, because the t

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Eric Pouech
Juan Lang a écrit : hmm sounds like most of the code we have in not in sync [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*d" | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep "%[0-9]*x" | wc -l 4136 This isn't a meaningful measu

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Juan Lang
> hmm sounds like most of the code we have in not in sync > > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*d" | wc -l > 8767 > [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep > "%[0-9]*x" | wc -l > 4136 This isn't a meaningful measurement. A %d

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech wrote: Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format? because others users want information in decimal, as any other debugger does. and

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Henri Verbeet
On 19 March 2010 10:03, Dmitry Timoshkov wrote: > I do care, because I have to dayly look at huge amount of logs, and having > backtraces print data in hex makes my life enormously easiler. > I don't care as strongly, but I agree with Dmitry that hexadecimal is more convenient.

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Dmitry Timoshkov
Eric Pouech wrote: > > Can I ask again, why to jump through the hoops if all required information > > is already there in appropriate and ready to use/easy to understand format? > > > > > because others users want information in decimal, as any other debugger > does. > and I do. It doesn't r

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-18 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech wrote: bt /x will do what you want. How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all re

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-16 Thread Dmitry Timoshkov
Eric Pouech wrote: > > >> bt /x will do what you want. > >> > > > > How will it help with all those backtraces generated and sent by users > > to bugzilla? Or those intermittent crashes which are very hard to reproduce? > > Is there any reason to spend any time again if all required informa

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-16 Thread Eric Pouech
bt /x will do what you want. How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend any time again if all required information is already there in appropriate and read

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-16 Thread Dmitry Timoshkov
Eric Pouech wrote: > > Eric Pouech wrote: > > > > > Gdb uses decimal notation by default for integers, so do we. > > > > GDB can use anything their developers think appropriate, my patch > > to use hex was intended to match Wine's relay traces and win32 > > header constants. This patch will make

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-16 Thread Dmitry Timoshkov
Eric Pouech wrote: > Gdb uses decimal notation by default for integers, so do we. GDB can use anything their developers think appropriate, my patch to use hex was intended to match Wine's relay traces and win32 header constants. This patch will make finding matches impossible again. -- Dmitry.